From: David Miller <davem@davemloft.net>
To: rahul.lakkireddy@chelsio.com
Cc: netdev@vger.kernel.org, linux-crypto@vger.kernel.org,
herbert@gondor.apana.org.au, nirranjan@chelsio.com,
atul.gupta@chelsio.com, vishal@chelsio.com, dt@chelsio.com
Subject: Re: [PATCH net-next 2/3] cxgb4: add UDP segmentation offload support
Date: Thu, 21 Nov 2019 12:02:18 -0800 (PST) [thread overview]
Message-ID: <20191121.120218.822468406949238769.davem@davemloft.net> (raw)
In-Reply-To: <2ddeefa22022f3949901c96892b8bf56a369f724.1574347161.git.rahul.lakkireddy@chelsio.com>
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Date: Thu, 21 Nov 2019 20:50:48 +0530
> @@ -1345,6 +1355,25 @@ static inline int cxgb4_validate_skb(struct sk_buff *skb,
> return 0;
> }
>
> +static inline void *write_eo_udp_wr(struct sk_buff *skb,
> + struct fw_eth_tx_eo_wr *wr, u32 hdr_len)
> +{
Do not use inline in foo.c files, let the compiler decide.
I know this source file is already a rotting mess of inline function
directives, but let's not add more.
next prev parent reply other threads:[~2019-11-21 20:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 15:20 [PATCH net-next 0/3] cxgb4: add UDP Segmentation Offload support Rahul Lakkireddy
2019-11-21 15:20 ` [PATCH net-next 1/3] cxgb4/chcr: update SGL DMA unmap for USO Rahul Lakkireddy
2019-11-21 15:20 ` [PATCH net-next 2/3] cxgb4: add UDP segmentation offload support Rahul Lakkireddy
2019-11-21 20:02 ` David Miller [this message]
2019-11-21 15:20 ` [PATCH net-next 3/3] cxgb4: add stats for MQPRIO QoS offload Tx path Rahul Lakkireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121.120218.822468406949238769.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=atul.gupta@chelsio.com \
--cc=dt@chelsio.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).