From: Herbert Xu <herbert@gondor.apana.org.au>
To: Harald Freudenberger <freude@linux.ibm.com>
Cc: linux-crypto@vger.kernel.org, ebiggers@kernel.org,
heiko.carstens@de.ibm.com, gor@linux.ibm.com
Subject: Re: [PATCH 3/3] crypto/testmgr: add selftests for paes-s390
Date: Fri, 22 Nov 2019 16:16:11 +0800 [thread overview]
Message-ID: <20191122081611.vznhvhouim6hnehc@gondor.apana.org.au> (raw)
In-Reply-To: <20191113105523.8007-4-freude@linux.ibm.com>
On Wed, Nov 13, 2019 at 11:55:23AM +0100, Harald Freudenberger wrote:
> This patch adds selftests for the s390 specific protected key
> AES (PAES) cipher implementations:
> * cbc-paes-s390
> * ctr-paes-s390
> * ecb-paes-s390
> * xts-paes-s390
> PAES is an AES cipher but with encrypted ('protected') key
> material. So here come ordinary AES enciphered data values
> but with a special key format understood by the PAES
> implementation.
>
> The testdata definitons and testlist entries are surrounded
> by #if IS_ENABLED(CONFIG_CRYPTO_PAES_S390) because they don't
> make any sense on non s390 platforms or without the PAES
> cipher implementation.
>
> Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>
> ---
> crypto/testmgr.c | 36 +++++
> crypto/testmgr.h | 334 +++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 370 insertions(+)
So with your cleartext work, I gather that you can now supply
arbitrary keys to paes? If so my preferred method of testing it
would be to add a paes-specific tester function that massaged the
existing aes vectors into the format required by paes so you
get exactly the same testing coverage as plain aes.
Is this possible?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2019-11-22 8:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 10:55 [PATCH 0/3] provide paes selftests Harald Freudenberger
2019-11-13 10:55 ` [PATCH 1/3] s390/pkey: Add support for key blob with clear key value Harald Freudenberger
2019-11-13 10:55 ` [PATCH 2/3] s390/crypto: Rework on paes implementation Harald Freudenberger
2019-11-22 8:13 ` Herbert Xu
2019-11-22 9:54 ` Harald Freudenberger
2019-11-22 10:42 ` Herbert Xu
2019-11-22 13:38 ` Harald Freudenberger
2019-11-22 14:07 ` Herbert Xu
2019-11-22 14:45 ` Harald Freudenberger
2019-11-13 10:55 ` [PATCH 3/3] crypto/testmgr: add selftests for paes-s390 Harald Freudenberger
2019-11-22 8:16 ` Herbert Xu [this message]
2019-11-22 9:11 ` Harald Freudenberger
2019-11-26 8:59 ` Herbert Xu
2020-01-31 11:06 ` Harald Freudenberger
2020-02-10 7:19 ` Harald Freudenberger
2020-02-11 2:38 ` Herbert Xu
2020-02-13 7:40 ` [PATCH] " Harald Freudenberger
2020-02-13 8:39 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122081611.vznhvhouim6hnehc@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ebiggers@kernel.org \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).