From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C648C43141 for ; Fri, 22 Nov 2019 11:27:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4196720672 for ; Fri, 22 Nov 2019 11:27:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726939AbfKVKdS (ORCPT ); Fri, 22 Nov 2019 05:33:18 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:51288 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726686AbfKVKdO (ORCPT ); Fri, 22 Nov 2019 05:33:14 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1iY6FT-0001nK-UT; Fri, 22 Nov 2019 18:33:11 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1iY6FR-000578-8W; Fri, 22 Nov 2019 18:33:09 +0800 Date: Fri, 22 Nov 2019 18:33:09 +0800 From: Herbert Xu To: Iuliana Prodan Cc: Horia Geanta , Aymen Sghaier , "David S. Miller" , Tom Lendacky , Gary Hook , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx Subject: Re: [PATCH 08/12] crypto: caam - support crypto_engine framework for SKCIPHER algorithms Message-ID: <20191122103309.wf2hg7km45ugzzhr@gondor.apana.org.au> References: <1574029845-22796-1-git-send-email-iuliana.prodan@nxp.com> <1574029845-22796-9-git-send-email-iuliana.prodan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1574029845-22796-9-git-send-email-iuliana.prodan@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Nov 18, 2019 at 12:30:41AM +0200, Iuliana Prodan wrote: > > +static int transfer_request_to_engine(struct crypto_engine *engine, > + struct crypto_async_request *req) > +{ > + switch (crypto_tfm_alg_type(req->tfm)) { > + case CRYPTO_ALG_TYPE_SKCIPHER: > + return crypto_transfer_skcipher_request_to_engine(engine, > + skcipher_request_cast(req)); > + default: > + return -EINVAL; > + } > +} Please don't do this. As you can see the crypto engine interface wants to you to use the correct type for the request object. That's what you should do to. In fact I don't understand why you're only using the crypto engine for the backlog case. Wouldn't it be much simpler if you used the engine unconditionally? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt