From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Daniel Jordan <daniel.m.jordan@oracle.com>,
Eric Biggers <ebiggers@kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [v3 PATCH] crypto: pcrypt - Avoid deadlock by using per-instance padata queues
Date: Wed, 27 Nov 2019 18:38:40 -0500 [thread overview]
Message-ID: <20191127233840.2yggxrlinztiueor@ca-dmjordan1.us.oracle.com> (raw)
In-Reply-To: <20191126075845.2v3woc3xqx2fxzqh@gondor.apana.org.au>
On Tue, Nov 26, 2019 at 03:58:45PM +0800, Herbert Xu wrote:
> On Tue, Nov 26, 2019 at 12:32:38AM -0500, Daniel Jordan wrote:
> >
> > I think it's possible for a task in padata_do_parallel() racing with another in
> > padata_replace() to use a pd after free. The synchronize_rcu() comes after the
> > pd_old->refcnt's are dec'd.
>
> Thanks. I've fixed this as well as the CPU mask issue you identified
> earlier.
I spent some time reviewing and testing this today, and the changes to
padata.h/c look fine to me.
Daniel
next prev parent reply other threads:[~2019-11-27 23:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 13:05 [PATCH] crypto: pcrypt - Avoid deadlock by using per-instance padata queues Herbert Xu
2019-11-19 17:37 ` Eric Biggers
2019-11-19 18:58 ` [v2 PATCH] " Herbert Xu
2019-11-22 16:28 ` Daniel Jordan
2019-11-26 5:32 ` Daniel Jordan
2019-11-26 7:58 ` [v3 " Herbert Xu
2019-11-27 19:14 ` Eric Biggers
2019-11-29 8:40 ` [PATCH] crypto: pcrypt - Do not clear MAY_SLEEP flag in original request Herbert Xu
2019-11-29 19:24 ` Eric Biggers
2019-11-27 23:38 ` Daniel Jordan [this message]
2019-11-29 19:25 ` [v3 PATCH] crypto: pcrypt - Avoid deadlock by using per-instance padata queues Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127233840.2yggxrlinztiueor@ca-dmjordan1.us.oracle.com \
--to=daniel.m.jordan@oracle.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).