From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A76B0C432C0 for ; Thu, 28 Nov 2019 21:30:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8419721781 for ; Thu, 28 Nov 2019 21:30:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726655AbfK1VaY (ORCPT ); Thu, 28 Nov 2019 16:30:24 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:49334 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726558AbfK1VaY (ORCPT ); Thu, 28 Nov 2019 16:30:24 -0500 Received: from localhost (c-73-35-209-67.hsd1.wa.comcast.net [73.35.209.67]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C8843145487A4; Thu, 28 Nov 2019 13:30:23 -0800 (PST) Date: Thu, 28 Nov 2019 13:30:23 -0800 (PST) Message-Id: <20191128.133023.1503723038764717212.davem@davemloft.net> To: Jason@zx2c4.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org Subject: Re: [PATCH v1] net: WireGuard secure network tunnel From: David Miller In-Reply-To: <20191127112643.441509-1-Jason@zx2c4.com> References: <20191127112643.441509-1-Jason@zx2c4.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 28 Nov 2019 13:30:24 -0800 (PST) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org From: "Jason A. Donenfeld" Date: Wed, 27 Nov 2019 12:26:43 +0100 > + do { > + next = skb->next; I've been trying desperately to remove all direct references to the SKB list implementation details so that we can convert it over to list_head. This means no direct references to skb->next nor skb->prev. Please rearrange this using appropriate helpers and abstractions from skbuff.h