linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 3/3] crypto: hmac - Use init_tfm/exit_tfm interface
Date: Fri, 6 Dec 2019 13:58:21 -0800	[thread overview]
Message-ID: <20191206215821.GC246840@gmail.com> (raw)
In-Reply-To: <E1id3Th-00078C-7M@gondobar>

On Fri, Dec 06, 2019 at 10:36:21AM +0800, Herbert Xu wrote:
> diff --git a/include/crypto/internal/hash.h b/include/crypto/internal/hash.h
> index bfc9db7b100d..7bf4181c7abb 100644
> --- a/include/crypto/internal/hash.h
> +++ b/include/crypto/internal/hash.h
> @@ -214,6 +214,12 @@ static inline struct shash_instance *shash_instance(
>  			    struct shash_instance, alg);
>  }
>  
> +static inline struct shash_instance *shash_alg_instance(	
> +	struct crypto_shash *shash)
> +{
> +	return shash_instance(crypto_tfm_alg_instance(&shash->base));
> +}
> +
>  static inline void *shash_instance_ctx(struct shash_instance *inst)
>  {
>  	return crypto_instance_ctx(shash_crypto_instance(inst));

Please run checkpatch:

ERROR: trailing whitespace
#86: FILE: include/crypto/internal/hash.h:223:
+static inline struct shash_instance *shash_alg_instance(^I$

- Eric

  reply	other threads:[~2019-12-06 21:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-06  2:35 [PATCH 0/3] crypto: shash - Enforce descsize limit in init_tfm Herbert Xu
2019-12-06  2:36 ` [PATCH 1/3] crypto: shash - Add init_tfm/exit_tfm and verify descsize Herbert Xu
2019-12-06 21:54   ` Eric Biggers
2019-12-06  2:36 ` [PATCH 2/3] crypto: padlock-sha - Use init_tfm/exit_tfm interface Herbert Xu
2019-12-06  2:36 ` [PATCH 3/3] crypto: hmac " Herbert Xu
2019-12-06 21:58   ` Eric Biggers [this message]
2019-12-08  5:42 ` [v2 PATCH 0/3] crypto: shash - Enforce descsize limit in init_tfm Herbert Xu
2019-12-08  5:42   ` [v2 PATCH 1/3] crypto: shash - Add init_tfm/exit_tfm and verify descsize Herbert Xu
2019-12-11  3:30     ` Eric Biggers
2019-12-08  5:42   ` [v2 PATCH 2/3] crypto: padlock-sha - Use init_tfm/exit_tfm interface Herbert Xu
2019-12-11  3:31     ` Eric Biggers
2019-12-08  5:42   ` [v2 PATCH 3/3] crypto: hmac " Herbert Xu
2019-12-11  3:32   ` [v2 PATCH 0/3] crypto: shash - Enforce descsize limit in init_tfm Eric Biggers
2019-12-11  8:30     ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191206215821.GC246840@gmail.com \
    --to=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).