From: Herbert Xu <herbert@gondor.apana.org.au>
To: Yunfeng Ye <yeyunfeng@huawei.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.or,
"hushiyuan@huawei.com" <hushiyuan@huawei.com>,
"linfeilong@huawei.com" <linfeilong@huawei.com>
Subject: Re: [PATCH] crypto: user - use macro CRYPTO_MSG_INDEX() to instead of index calculation
Date: Tue, 10 Dec 2019 21:39:24 +0800 [thread overview]
Message-ID: <20191210133923.aab65usf4xyqd3wv@gondor.apana.org.au> (raw)
In-Reply-To: <6306e685-51fa-1a04-e9d9-07d4c80b5400@huawei.com>
On Tue, Dec 10, 2019 at 07:07:36PM +0800, Yunfeng Ye wrote:
> There are multiple places using CRYPTO_MSG_BASE to calculate the index,
> so use macro CRYPTO_MSG_INDEX() instead for better readability.
>
> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
I don't think your patch makes it any more readable.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2019-12-10 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 11:07 [PATCH] crypto: user - use macro CRYPTO_MSG_INDEX() to instead of index calculation Yunfeng Ye
2019-12-10 13:39 ` Herbert Xu [this message]
2019-12-10 14:27 ` Yunfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210133923.aab65usf4xyqd3wv@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=hushiyuan@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.or \
--cc=yeyunfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).