From: Herbert Xu <herbert@gondor.apana.org.au>
To: Kees Cook <keescook@chromium.org>
Cc: "João Moreira" <joao.moreira@intel.com>,
"Eric Biggers" <ebiggers@kernel.org>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Sami Tolvanen" <samitolvanen@google.com>,
"Stephan Mueller" <smueller@chronox.de>,
x86@kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH v7] crypto: x86: Regularize glue function prototypes
Date: Wed, 11 Dec 2019 17:38:44 +0800 [thread overview]
Message-ID: <20191211093844.vwguh6yjgab5hza5@gondor.apana.org.au> (raw)
In-Reply-To: <201911262205.FD985935F@keescook>
On Tue, Nov 26, 2019 at 10:08:02PM -0800, Kees Cook wrote:
> The crypto glue performed function prototype casting via macros to make
> indirect calls to assembly routines. Instead of performing casts at the
> call sites (which trips Control Flow Integrity prototype checking), switch
> each prototype to a common standard set of arguments which allows the
> removal of the existing macros. In order to keep pointer math unchanged,
> internal casting between u128 pointers and u8 pointers is added.
>
> Co-developed-by: João Moreira <joao.moreira@intel.com>
> Signed-off-by: João Moreira <joao.moreira@intel.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> v7:
> - added João's SoB (ebiggers)
> - corrected aesni .S prototype comments (ebiggers)
> - collapsed glue series into a single patch (ebiggers)
> v6: https://lore.kernel.org/lkml/20191122010334.12081-1-keescook@chromium.org
> v5: https://lore.kernel.org/lkml/20191113182516.13545-1-keescook@chromium.org
> v4: https://lore.kernel.org/lkml/20191111214552.36717-1-keescook@chromium.org
> v3: https://lore.kernel.org/lkml/20190507161321.34611-1-keescook@chromium.org
> ---
> arch/x86/crypto/aesni-intel_asm.S | 8 +--
> arch/x86/crypto/aesni-intel_glue.c | 45 ++++++-------
> arch/x86/crypto/camellia_aesni_avx2_glue.c | 74 ++++++++++-----------
> arch/x86/crypto/camellia_aesni_avx_glue.c | 72 +++++++++------------
> arch/x86/crypto/camellia_glue.c | 45 +++++++------
> arch/x86/crypto/cast6_avx_glue.c | 68 +++++++++-----------
> arch/x86/crypto/glue_helper.c | 23 ++++---
> arch/x86/crypto/serpent_avx2_glue.c | 65 +++++++++----------
> arch/x86/crypto/serpent_avx_glue.c | 63 +++++++++---------
> arch/x86/crypto/serpent_sse2_glue.c | 30 +++++----
> arch/x86/crypto/twofish_avx_glue.c | 75 ++++++++++------------
> arch/x86/crypto/twofish_glue_3way.c | 37 ++++++-----
> arch/x86/include/asm/crypto/camellia.h | 63 +++++++++---------
> arch/x86/include/asm/crypto/glue_helper.h | 18 ++----
> arch/x86/include/asm/crypto/serpent-avx.h | 20 +++---
> arch/x86/include/asm/crypto/serpent-sse2.h | 28 ++++----
> arch/x86/include/asm/crypto/twofish.h | 19 +++---
> crypto/cast6_generic.c | 18 +++---
> crypto/serpent_generic.c | 6 +-
> include/crypto/cast6.h | 4 +-
> include/crypto/serpent.h | 4 +-
> include/crypto/xts.h | 2 -
> 22 files changed, 374 insertions(+), 413 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-12-11 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 6:08 [PATCH v7] crypto: x86: Regularize glue function prototypes Kees Cook
2019-11-27 18:01 ` Eric Biggers
2019-12-11 9:38 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211093844.vwguh6yjgab5hza5@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ard.biesheuvel@linaro.org \
--cc=ebiggers@kernel.org \
--cc=joao.moreira@intel.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=smueller@chronox.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).