From: Herbert Xu <herbert@gondor.apana.org.au>
To: Kees Cook <keescook@chromium.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-crypto@vger.kernel.org,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [PATCH v3] crypto, x86/sha: Eliminate casts on asm implementations
Date: Wed, 22 Jan 2020 18:13:24 +0800 [thread overview]
Message-ID: <20200122101324.zitzy7doyh3nlzuh@gondor.apana.org.au> (raw)
In-Reply-To: <202001141955.C4136E9C5@keescook>
On Tue, Jan 14, 2020 at 07:57:29PM -0800, Kees Cook wrote:
> In order to avoid CFI function prototype mismatches, this removes the
> casts on assembly implementations of sha1/256/512 accelerators. The
> safety checks from BUILD_BUG_ON() remain.
>
> Additionally, this renames various arguments for clarity, as suggested
> by Eric Biggers.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> v3: fix missed variable name change, now correctly allmodconfig build tested
> v2: https://lore.kernel.org/lkml/202001141825.8CD52D0@keescook
> v1: https://lore.kernel.org/lkml/20191122030620.GD32523@sol.localdomain/
> ---
> arch/x86/crypto/sha1_avx2_x86_64_asm.S | 6 +--
> arch/x86/crypto/sha1_ssse3_asm.S | 14 ++++--
> arch/x86/crypto/sha1_ssse3_glue.c | 70 +++++++++++---------------
> arch/x86/crypto/sha256-avx-asm.S | 4 +-
> arch/x86/crypto/sha256-avx2-asm.S | 4 +-
> arch/x86/crypto/sha256-ssse3-asm.S | 6 ++-
> arch/x86/crypto/sha256_ssse3_glue.c | 34 ++++++-------
> arch/x86/crypto/sha512-avx-asm.S | 11 ++--
> arch/x86/crypto/sha512-avx2-asm.S | 11 ++--
> arch/x86/crypto/sha512-ssse3-asm.S | 13 +++--
> arch/x86/crypto/sha512_ssse3_glue.c | 31 ++++++------
> 11 files changed, 102 insertions(+), 102 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-01-22 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 3:57 [PATCH v3] crypto, x86/sha: Eliminate casts on asm implementations Kees Cook
2020-01-22 10:08 ` Kees Cook
2020-01-22 10:13 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122101324.zitzy7doyh3nlzuh@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ebiggers@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).