From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Horia Geanta <horia.geanta@nxp.com>
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] hwrng: imx-rngc: improve dependencies
Date: Wed, 12 Feb 2020 21:45:07 +0100 [thread overview]
Message-ID: <20200212204507.u4slynuvztxjxbef@pengutronix.de> (raw)
In-Reply-To: <VI1PR0402MB3485267DA0BBAD58556611D1981B0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
On Wed, Feb 12, 2020 at 07:51:46PM +0000, Horia Geanta wrote:
> On 2/5/2020 4:00 PM, Uwe Kleine-König wrote:
> > The imx-rngc driver binds to devices that are compatible to
> > "fsl,imx25-rngb". Grepping through the device tree sources suggests this
> > only exists on i.MX25. So restrict dependencies to configs that have
> The driver could also be used by some i.MX6 SoCs (SL, SLL),
> that have a compatible rngb.
>
> Actually i.MX6SL has a rngb node in the DT, but unfortunately it lacks
> a compatible string.
Also the i.MX6ULL might have a compatible device?
> I am planning to address this short term.
>
> > this SoC enabled, but allow compile testing. For the latter additional
> > dependencies for clk and readl/writel are necessary.
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > drivers/char/hw_random/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> > index 8486c29d8324..17fe954fccde 100644
> > --- a/drivers/char/hw_random/Kconfig
> > +++ b/drivers/char/hw_random/Kconfig
> > @@ -244,7 +244,8 @@ config HW_RANDOM_MXC_RNGA
> >
> > config HW_RANDOM_IMX_RNGC
> > tristate "Freescale i.MX RNGC Random Number Generator"
> > - depends on ARCH_MXC
> > + depends on HAS_IOMEM && HAVE_CLK
> > + depends on SOC_IMX25 || COMPILE_TEST
> I guess SOC_IMX6SL and SOC_IMX6SLL will have to be added.
> Does this sound good?
I'd say currently the patch is right and once the device trees for the
imx6 variants were expanded to include these, the list here can be
expanded.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2020-02-12 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 14:00 [PATCH] hwrng: imx-rngc: improve dependencies Uwe Kleine-König
2020-02-12 19:51 ` Horia Geanta
2020-02-12 20:45 ` Uwe Kleine-König [this message]
2020-02-22 1:41 ` Herbert Xu
2020-02-15 17:16 Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212204507.u4slynuvztxjxbef@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).