Linux-Crypto Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] crypto: tcrypt - fix printed skcipher [a]sync mode
@ 2020-02-05 10:19 Horia Geantă
  2020-02-05 10:24 ` Horia Geanta
  2020-02-13  9:25 ` Herbert Xu
  0 siblings, 2 replies; 3+ messages in thread
From: Horia Geantă @ 2020-02-05 10:19 UTC (permalink / raw)
  To: Herbert Xu; +Cc: David S. Miller, linux-crypto, NXP Linux Team

When running tcrypt skcipher speed tests, logs contain things like:
testing speed of async ecb(des3_ede) (ecb(des3_ede-generic)) encryption
or:
testing speed of async ecb(aes) (ecb(aes-ce)) encryption

The algorithm implementations are sync, not async.
Fix this inaccuracy.

Fixes: 7166e589da5b6 ("7166e589da5b crypto: tcrypt - Use skcipher")
Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
---
 crypto/tcrypt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index f42f486e90e8..ba0b7702f2e9 100644
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@ -1514,8 +1514,8 @@ static void test_skcipher_speed(const char *algo, int enc, unsigned int secs,
 		return;
 	}
 
-	pr_info("\ntesting speed of async %s (%s) %s\n", algo,
-			get_driver_name(crypto_skcipher, tfm), e);
+	pr_info("\ntesting speed of %s %s (%s) %s\n", async ? "async" : "sync",
+		algo, get_driver_name(crypto_skcipher, tfm), e);
 
 	req = skcipher_request_alloc(tfm, GFP_KERNEL);
 	if (!req) {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: tcrypt - fix printed skcipher [a]sync mode
  2020-02-05 10:19 [PATCH] crypto: tcrypt - fix printed skcipher [a]sync mode Horia Geantă
@ 2020-02-05 10:24 ` Horia Geanta
  2020-02-13  9:25 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Horia Geanta @ 2020-02-05 10:24 UTC (permalink / raw)
  To: Herbert Xu; +Cc: David S. Miller, linux-crypto, dl-linux-imx

On 2/5/2020 12:20 PM, Horia Geantă wrote:
> When running tcrypt skcipher speed tests, logs contain things like:
> testing speed of async ecb(des3_ede) (ecb(des3_ede-generic)) encryption
> or:
> testing speed of async ecb(aes) (ecb(aes-ce)) encryption
> 
> The algorithm implementations are sync, not async.
> Fix this inaccuracy.
> 
> Fixes: 7166e589da5b6 ("7166e589da5b crypto: tcrypt - Use skcipher")
Just noticed the typo in the Fixes tag.
Let me know if you could fix this before applying (in case
this is the only issue with the patch), or you want me to send v2.

Thanks,
Horia

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: tcrypt - fix printed skcipher [a]sync mode
  2020-02-05 10:19 [PATCH] crypto: tcrypt - fix printed skcipher [a]sync mode Horia Geantă
  2020-02-05 10:24 ` Horia Geanta
@ 2020-02-13  9:25 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2020-02-13  9:25 UTC (permalink / raw)
  To: Horia Geantă; +Cc: David S. Miller, linux-crypto, NXP Linux Team

On Wed, Feb 05, 2020 at 12:19:58PM +0200, Horia Geantă wrote:
> When running tcrypt skcipher speed tests, logs contain things like:
> testing speed of async ecb(des3_ede) (ecb(des3_ede-generic)) encryption
> or:
> testing speed of async ecb(aes) (ecb(aes-ce)) encryption
> 
> The algorithm implementations are sync, not async.
> Fix this inaccuracy.
> 
> Fixes: 7166e589da5b6 ("7166e589da5b crypto: tcrypt - Use skcipher")
> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
> ---
>  crypto/tcrypt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05 10:19 [PATCH] crypto: tcrypt - fix printed skcipher [a]sync mode Horia Geantă
2020-02-05 10:24 ` Horia Geanta
2020-02-13  9:25 ` Herbert Xu

Linux-Crypto Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-crypto/0 linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ https://lore.kernel.org/linux-crypto \
		linux-crypto@vger.kernel.org
	public-inbox-index linux-crypto

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-crypto


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git