From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB65FC3F2C6 for ; Fri, 28 Feb 2020 00:31:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF58224691 for ; Fri, 28 Feb 2020 00:31:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730247AbgB1AbB (ORCPT ); Thu, 27 Feb 2020 19:31:01 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:55586 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730117AbgB1AbB (ORCPT ); Thu, 27 Feb 2020 19:31:01 -0500 Received: from gwarestrin.me.apana.org.au ([192.168.0.7] helo=gwarestrin.arnor.me.apana.org.au) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1j7TYK-0008Qp-Q2; Fri, 28 Feb 2020 11:30:54 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 28 Feb 2020 11:30:52 +1100 Date: Fri, 28 Feb 2020 11:30:52 +1100 From: Herbert Xu To: Corentin Labbe Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] crypto: drbg: DRBG_CTR should select CTR Message-ID: <20200228003052.GA9060@gondor.apana.org.au> References: <1582127495-5871-1-git-send-email-clabbe@baylibre.com> <1582127495-5871-2-git-send-email-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1582127495-5871-2-git-send-email-clabbe@baylibre.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Feb 19, 2020 at 03:51:35PM +0000, Corentin Labbe wrote: > if CRYPTO_DRBG_CTR is builtin and CTR is module, allocating such algo > will fail. > DRBG: could not allocate CTR cipher TFM handle: ctr(aes) > alg: drbg: Failed to reset rng > alg: drbg: Test 0 failed for drbg_pr_ctr_aes128 > DRBG: could not allocate CTR cipher TFM handle: ctr(aes) > alg: drbg: Failed to reset rng > alg: drbg: Test 0 failed for drbg_nopr_ctr_aes128 > DRBG: could not allocate CTR cipher TFM handle: ctr(aes) > alg: drbg: Failed to reset rng > alg: drbg: Test 0 failed for drbg_nopr_ctr_aes192 > DRBG: could not allocate CTR cipher TFM handle: ctr(aes) > alg: drbg: Failed to reset rng > ialg: drbg: Test 0 failed for drbg_nopr_ctr_aes256 > > Since setting DRBG_CTR=CTR lead to a recursive dependency, let's depends > on CTR=y > > Signed-off-by: Corentin Labbe > --- > crypto/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/crypto/Kconfig b/crypto/Kconfig > index 6d27fc6a7bf5..eddeb43fc01c 100644 > --- a/crypto/Kconfig > +++ b/crypto/Kconfig > @@ -1822,7 +1822,7 @@ config CRYPTO_DRBG_HASH > config CRYPTO_DRBG_CTR > bool "Enable CTR DRBG" > select CRYPTO_AES > - depends on CRYPTO_CTR > + depends on CRYPTO_CTR=y This should be turned into a select. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt