From: Herbert Xu <herbert@gondor.apana.org.au>
To: Kalyani Akula <kalyani.akula@xilinx.com>
Cc: davem@davemloft.net, monstr@seznam.cz,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Kalyani Akula <kalyania@xilinx.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, git-dev@xilinx.com,
Mohan Marutirao Dhanawade <mohan.dhanawade@xilinx.com>,
Sarat Chand Savitala <saratcha@xilinx.com>,
Harsh Jain <harshj@xilinx.com>, Michal Simek <michals@xilinx.com>
Subject: Re: [PATCH V7 0/4] Add Xilinx's ZynqMP AES-GCM driver support
Date: Fri, 28 Feb 2020 11:50:34 +1100 [thread overview]
Message-ID: <20200228005033.GA9506@gondor.apana.org.au> (raw)
In-Reply-To: <1581935204-25673-1-git-send-email-kalyani.akula@xilinx.com>
On Mon, Feb 17, 2020 at 03:56:40PM +0530, Kalyani Akula wrote:
> This patch set adds support for
> - dt-binding docs for Xilinx ZynqMP AES driver
> - Adds device tree node for ZynqMP AES driver
> - Adds communication layer support for aes in zynqmp.c
> - Adds Xilinx ZynqMP driver for AES Algorithm
>
> NOTE: This patchset is based on Michal's branch
> https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=arm/drivers
> because of possible merge conflict for 1/4 patch with below commit
> commit 461011b1e1ab ("drivers: firmware: xilinx: Add support for feature check")
>
> V7 Changes:
> - Rebased this patchset on Cryptodev-2.6 tree and fixed compilation
> issue seen. The issue is seen due to the below
> commit af5034e8e4a5("crypto: remove propagation of CRYPTO_TFM_RES_* flags")
>
> V6 Changes:
> - Updated SPDX-License-Identifier in xlnx,zynqmp-aes.yaml.
>
> V5 Changes :
> - Moved arm64: zynqmp: Add Xilinx AES node from 2/4 to 4/4.
> - Moved crypto: Add Xilinx AES driver patch from 4/4 to 3/4.
> - Moved dt-bindings patch from 1/4 to 2/4
> - Moved firmware: xilinx: Add ZynqMP aes API for AES patch from 3/4 to 1/4
> - Converted dt-bindings from .txt to .yaml format.
> - Corrected typo in the subject.
> - Updated zynqmp-aes node to correct location.
> - Replaced ARCH_ZYNQMP with ZYNQMP_FIRMWARE in Kconfig
> - Removed extra new lines and added wherever necessary.
> - Updated Signed-off-by sequence.
> - Ran checkpatch for all patches in the series.
>
> V4 Changes :
> - Addressed review comments.
>
> V3 Changes :
> - Added software fallback in cases where Hardware doesn't have
> the capability to handle the request.
> - Removed use of global variable for storing the driver data.
> - Enabled CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y and executed all
> the kernel selftests. Also covered tests with tcrypt module.
>
> V2 Changes :
> - Converted RFC PATCH to PATCH
> - Removed ALG_SET_KEY_TYPE that was added to support keytype
> attribute. Taken using setkey interface.
> - Removed deprecated BLKCIPHER in Kconfig
> - Erased Key/IV from the buffer.
> - Renamed zynqmp-aes driver to zynqmp-aes-gcm.
> - Addressed few other review comments
>
>
> Kalyani Akula (4):
> firmware: xilinx: Add ZynqMP aes API for AES functionality
> dt-bindings: crypto: Add bindings for ZynqMP AES-GCM driver
> crypto: Add Xilinx AES driver
> arm64: zynqmp: Add Xilinx AES node.
>
> .../bindings/crypto/xlnx,zynqmp-aes.yaml | 37 ++
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 +
> drivers/crypto/Kconfig | 12 +
> drivers/crypto/Makefile | 1 +
> drivers/crypto/xilinx/Makefile | 2 +
> drivers/crypto/xilinx/zynqmp-aes-gcm.c | 457 +++++++++++++++++++++
> drivers/firmware/xilinx/zynqmp.c | 25 ++
> include/linux/firmware/xlnx-zynqmp.h | 2 +
> 8 files changed, 540 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/crypto/xlnx,zynqmp-aes.yaml
> create mode 100644 drivers/crypto/xilinx/Makefile
> create mode 100644 drivers/crypto/xilinx/zynqmp-aes-gcm.c
Patches 1-3 applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-02-28 0:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 10:26 [PATCH V7 0/4] Add Xilinx's ZynqMP AES-GCM driver support Kalyani Akula
2020-02-17 10:26 ` [PATCH V7 1/4] firmware: xilinx: Add ZynqMP aes API for AES functionality Kalyani Akula
2020-02-17 10:26 ` [PATCH V7 2/4] dt-bindings: crypto: Add bindings for ZynqMP AES-GCM driver Kalyani Akula
2020-02-17 10:26 ` [PATCH V7 3/4] crypto: Add Xilinx AES driver Kalyani Akula
2020-02-17 10:26 ` [PATCH V7 4/4] arm64: zynqmp: Add Xilinx AES node Kalyani Akula
2020-02-28 7:11 ` Michal Simek
2020-02-28 0:50 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228005033.GA9506@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=git-dev@xilinx.com \
--cc=harshj@xilinx.com \
--cc=kalyani.akula@xilinx.com \
--cc=kalyania@xilinx.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=mohan.dhanawade@xilinx.com \
--cc=monstr@seznam.cz \
--cc=robh+dt@kernel.org \
--cc=saratcha@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).