Re: [PATCH 1/4] crypto: hisilicon/qm - Put device finding logic into QM

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2565 bytes --]

Hi Shukun,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on cryptodev/master]
[also build test ERROR on next-20200304]
[cannot apply to crypto/master v5.6-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Shukun-Tan/crypto-hisilicon-Refactor-find-device-related-code/20200305-013355
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/crypto/hisilicon/qm.c: In function 'hisi_qm_sort_devices':
>> drivers/crypto/hisilicon/qm.c:2230:20: error: 'struct device' has no member named 'numa_node'; did you mean 'of_node'?
       dev_node = dev->numa_node;
                       ^~~~~~~~~
                       of_node

vim +2230 drivers/crypto/hisilicon/qm.c

  2216	
  2217	static int hisi_qm_sort_devices(int node, struct list_head *head,
  2218					struct hisi_qm_list *qm_list)
  2219	{
  2220		struct hisi_qm_resource *res, *tmp;
  2221		struct hisi_qm *qm;
  2222		struct list_head *n;
  2223		struct device *dev;
  2224		int dev_node = 0;
  2225	
  2226		list_for_each_entry(qm, &qm_list->list, list) {
  2227			dev = &qm->pdev->dev;
  2228	
  2229			if (IS_ENABLED(CONFIG_NUMA)) {
> 2230				dev_node = dev->numa_node;
  2231				if (dev_node < 0)
  2232					dev_node = 0;
  2233			}
  2234	
  2235			res = kzalloc(sizeof(*res), GFP_KERNEL);
  2236			if (!res)
  2237				return -ENOMEM;
  2238	
  2239			res->qm = qm;
  2240			res->distance = node_distance(dev_node, node);
  2241			n = head;
  2242			list_for_each_entry(tmp, head, list) {
  2243				if (res->distance < tmp->distance) {
  2244					n = &tmp->list;
  2245					break;
  2246				}
  2247			}
  2248			list_add_tail(&res->list, n);
  2249		}
  2250	
  2251		return 0;
  2252	}
  2253	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 62126 bytes --]