From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DDAFC3F2D8 for ; Fri, 6 Mar 2020 01:51:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 10B242073B for ; Fri, 6 Mar 2020 01:51:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726191AbgCFBvN (ORCPT ); Thu, 5 Mar 2020 20:51:13 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:46098 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726243AbgCFBvM (ORCPT ); Thu, 5 Mar 2020 20:51:12 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1jA28t-0008BS-Ks; Fri, 06 Mar 2020 09:51:11 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1jA28r-0006mL-En; Fri, 06 Mar 2020 09:51:09 +0800 Date: Fri, 6 Mar 2020 09:51:09 +0800 From: Herbert Xu To: Eric Biggers Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH 00/12] crypto: more template instantiation cleanups Message-ID: <20200306015109.dahx6vg7knp2hcw7@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226045924.97053-1-ebiggers@kernel.org> X-Newsgroups: apana.lists.os.linux.cryptoapi Organization: Core User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Eric Biggers wrote: > This series simplifies error handling in the remaining crypto templates, > taking advantage of the changes I made last release that made > crypto_grab_*() accept ERR_PTR() names and crypto_drop_*() accept > spawns that haven't been grabbed yet: > https://lore.kernel.org/r/20200103035908.12048-1-ebiggers@kernel.org > > Many templates were already converted to the new style by that series. > This series just handles the remainder. > > This series is an internal cleanup only; there are no changes for users > of the crypto API. Net change is 124 lines of code removed. > > Eric Biggers (12): > crypto: authencesn - fix weird comma-terminated line > crypto: ccm - simplify error handling in crypto_rfc4309_create() > crypto: cryptd - simplify error handling in cryptd_create_*() > crypto: ctr - simplify error handling in crypto_rfc3686_create() > crypto: cts - simplify error handling in crypto_cts_create() > crypto: gcm - simplify error handling in crypto_rfc4106_create() > crypto: gcm - simplify error handling in crypto_rfc4543_create() > crypto: geniv - simply error handling in aead_geniv_alloc() > crypto: lrw - simplify error handling in create() > crypto: pcrypt - simplify error handling in pcrypt_create_aead() > crypto: rsa-pkcs1pad - simplify error handling in pkcs1pad_create() > crypto: xts - simplify error handling in ->create() > > crypto/authencesn.c | 2 +- > crypto/ccm.c | 29 ++++++------------- > crypto/cryptd.c | 37 ++++++++---------------- > crypto/ctr.c | 29 ++++++------------- > crypto/cts.c | 27 ++++++------------ > crypto/gcm.c | 66 ++++++++++++++----------------------------- > crypto/geniv.c | 17 ++++------- > crypto/lrw.c | 28 ++++++++---------- > crypto/pcrypt.c | 33 ++++++---------------- > crypto/rsa-pkcs1pad.c | 59 +++++++++++++------------------------- > crypto/xts.c | 28 ++++++++---------- > kernel/padata.c | 7 +++-- > 12 files changed, 119 insertions(+), 243 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt