From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34542C3F2D1 for ; Fri, 6 Mar 2020 01:52:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 149C620726 for ; Fri, 6 Mar 2020 01:52:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726317AbgCFBwS (ORCPT ); Thu, 5 Mar 2020 20:52:18 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:46164 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726243AbgCFBwS (ORCPT ); Thu, 5 Mar 2020 20:52:18 -0500 Received: from gwarestrin.me.apana.org.au ([192.168.0.7] helo=gwarestrin.arnor.me.apana.org.au) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1jA29p-0005uw-Cd; Fri, 06 Mar 2020 12:52:10 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 06 Mar 2020 12:52:09 +1100 Date: Fri, 6 Mar 2020 12:52:09 +1100 From: Herbert Xu To: Andrei Botila Cc: Horia Geanta , Aymen Sghaier , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Andrei Botila , stable@vger.kernel.org Subject: Re: [PATCH] crypto: caam - update xts sector size for large input length Message-ID: <20200306015209.GL30653@gondor.apana.org.au> References: <20200228104648.18898-1-andrei.botila@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200228104648.18898-1-andrei.botila@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Feb 28, 2020 at 12:46:48PM +0200, Andrei Botila wrote: > From: Andrei Botila > > Since in the software implementation of XTS-AES there is > no notion of sector every input length is processed the same way. > CAAM implementation has the notion of sector which causes different > results between the software implementation and the one in CAAM > for input lengths bigger than 512 bytes. > Increase sector size to maximum value on 16 bits. > > Fixes: c6415a6016bf ("crypto: caam - add support for acipher xts(aes)") > Cc: # v4.12+ > Signed-off-by: Andrei Botila > --- > This patch needs to be applied from v4.12+ because dm-crypt has added support > for 4K sector size at that version. The commit was > 8f0009a225171 ("dm-crypt: optionally support larger encryption sector size"). > > drivers/crypto/caam/caamalg_desc.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt