From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Eric Biggers <ebiggers@kernel.org>,
Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Daniel Jordan <daniel.m.jordan@oracle.com>,
Robin Murphy <robin.murphy@arm.com>,
mark.rutland@arm.com, jiangshanlai@gmail.com,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
tj@kernel.org, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: WARNING: at kernel/workqueue.c:1473 __queue_work+0x3b8/0x3d0
Date: Fri, 6 Mar 2020 11:12:22 -0500 [thread overview]
Message-ID: <20200306161222.wsx6nx26f7u7vabf@ca-dmjordan1.us.oracle.com> (raw)
In-Reply-To: <20200303224327.GA89804@sol.localdomain>
On Tue, Mar 03, 2020 at 02:43:27PM -0800, Eric Biggers wrote:
> Probably the request_module() is coming from the registration-time crypto
> self-tests allocating the generic implementation of algorithm when an
> architecture-specific implementation is registered. This occurs when
> CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y on Linux v5.2 and later.
Ok, I can confirm that if we get the debug output from one of Corentin's
boards.
> If this is causing problems we could do:
>
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c
> index ccb3d60729fc..d89791700b88 100644
> --- a/crypto/testmgr.c
> +++ b/crypto/testmgr.c
> @@ -1667,7 +1667,7 @@ static int test_hash_vs_generic_impl(const char *driver,
> if (strcmp(generic_driver, driver) == 0) /* Already the generic impl? */
> return 0;
>
> - generic_tfm = crypto_alloc_shash(generic_driver, 0, 0);
> + generic_tfm = crypto_alloc_shash(generic_driver, 0, CRYPTO_NOLOAD);
> if (IS_ERR(generic_tfm)) {
> err = PTR_ERR(generic_tfm);
> if (err == -ENOENT) {
> @@ -2389,7 +2389,7 @@ static int test_aead_vs_generic_impl(struct aead_extra_tests_ctx *ctx)
> if (strcmp(generic_driver, driver) == 0) /* Already the generic impl? */
> return 0;
>
> - generic_tfm = crypto_alloc_aead(generic_driver, 0, 0);
> + generic_tfm = crypto_alloc_aead(generic_driver, 0, CRYPTO_NOLOAD);
> if (IS_ERR(generic_tfm)) {
> err = PTR_ERR(generic_tfm);
> if (err == -ENOENT) {
> @@ -2993,7 +2993,7 @@ static int test_skcipher_vs_generic_impl(const char *driver,
> if (strcmp(generic_driver, driver) == 0) /* Already the generic impl? */
> return 0;
>
> - generic_tfm = crypto_alloc_skcipher(generic_driver, 0, 0);
> + generic_tfm = crypto_alloc_skcipher(generic_driver, 0, CRYPTO_NOLOAD);
> if (IS_ERR(generic_tfm)) {
> err = PTR_ERR(generic_tfm);
> if (err == -ENOENT) {
>
>
> ... but that's not ideal, since it would mean that if someone builds all crypto
> algorithms as modules, then the comparison tests could be unnecessarily skipped.
We should try to avoid this then.
> But it is really always wrong to be calling request_module() from other
> module_init() functions? The commit that added 'init_free_wq' was also
> introduced in v5.2; maybe that's the problem here?
>
> commit 1a7b7d9220819afe79d1ec5d759fe4349bd2453e
> Author: Rick Edgecombe <rick.p.edgecombe@intel.com>
> Date: Thu Apr 25 17:11:37 2019 -0700
>
> modules: Use vmalloc special flag
Yes, I don't see a reason init_free_wq has to be initialized that late.
next prev parent reply other threads:[~2020-03-06 16:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200217204803.GA13479@Red>
[not found] ` <20200218163504.y5ofvaejleuf5tbh@ca-dmjordan1.us.oracle.com>
2020-02-20 9:03 ` WARNING: at kernel/workqueue.c:1473 __queue_work+0x3b8/0x3d0 Corentin Labbe
2020-02-21 17:42 ` Daniel Jordan
2020-02-28 12:33 ` Will Deacon
2020-02-28 15:33 ` Daniel Jordan
2020-03-01 17:53 ` Corentin Labbe
2020-03-02 17:25 ` Daniel Jordan
2020-03-02 18:00 ` Robin Murphy
2020-03-03 21:30 ` Daniel Jordan
2020-03-03 22:43 ` Eric Biggers
2020-03-06 16:12 ` Daniel Jordan [this message]
2020-10-01 17:50 ` Corentin Labbe
2020-10-05 17:09 ` Daniel Jordan
2020-10-07 19:41 ` Corentin Labbe
2020-10-08 17:07 ` Daniel Jordan
2020-03-03 7:48 ` Corentin Labbe
2020-03-03 21:31 ` Daniel Jordan
2020-09-25 18:12 ` Corentin Labbe
2020-09-30 18:18 ` Daniel Jordan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306161222.wsx6nx26f7u7vabf@ca-dmjordan1.us.oracle.com \
--to=daniel.m.jordan@oracle.com \
--cc=clabbe.montjoie@gmail.com \
--cc=ebiggers@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=tj@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).