linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] crypto: qat - simplify the qat_crypto function
@ 2020-03-03 15:48 Tianjia Zhang
  2020-03-12 12:38 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Tianjia Zhang @ 2020-03-03 15:48 UTC (permalink / raw)
  To: giovanni.cabiddu, herbert, davem, ebiggers, pvanleeuwen, zohar
  Cc: qat-linux, linux-crypto, linux-kernel

simplify code to remove unnecessary constant string copies.

Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
---
 drivers/crypto/qat/qat_common/qat_crypto.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/crypto/qat/qat_common/qat_crypto.c b/drivers/crypto/qat/qat_common/qat_crypto.c
index 3852d31ce0a4..fb504cee0305 100644
--- a/drivers/crypto/qat/qat_common/qat_crypto.c
+++ b/drivers/crypto/qat/qat_common/qat_crypto.c
@@ -250,8 +250,7 @@ static int qat_crypto_create_instances(struct adf_accel_dev *accel_dev)
 	char val[ADF_CFG_MAX_VAL_LEN_IN_BYTES];
 
 	INIT_LIST_HEAD(&accel_dev->crypto_list);
-	strlcpy(key, ADF_NUM_CY, sizeof(key));
-	if (adf_cfg_get_param_value(accel_dev, SEC, key, val))
+	if (adf_cfg_get_param_value(accel_dev, SEC, ADF_NUM_CY, val))
 		return -EFAULT;
 
 	if (kstrtoul(val, 0, &num_inst))
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] crypto: qat - simplify the qat_crypto function
  2020-03-03 15:48 [PATCH] crypto: qat - simplify the qat_crypto function Tianjia Zhang
@ 2020-03-12 12:38 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2020-03-12 12:38 UTC (permalink / raw)
  To: Tianjia Zhang
  Cc: giovanni.cabiddu, davem, ebiggers, pvanleeuwen, zohar, qat-linux,
	linux-crypto, linux-kernel

On Tue, Mar 03, 2020 at 11:48:09PM +0800, Tianjia Zhang wrote:
> simplify code to remove unnecessary constant string copies.
> 
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> ---
>  drivers/crypto/qat/qat_common/qat_crypto.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-12 12:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-03 15:48 [PATCH] crypto: qat - simplify the qat_crypto function Tianjia Zhang
2020-03-12 12:38 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).