From: "Jason A. Donenfeld" <Jason@zx2c4.com> To: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>, Linus Torvalds <torvalds@linux-foundation.org>, Masahiro Yamada <yamada.masahiro@socionext.com>, x86@kernel.org, linux-crypto@vger.kernel.org Subject: [PATCH RFC 0/3] x86: probe for assembler capabilities in Kconfig Date: Fri, 20 Mar 2020 18:49:42 -0600 [thread overview] Message-ID: <20200321004945.451497-1-Jason@zx2c4.com> (raw) In-Reply-To: <CAHk-=wjbTF2iw3EbKgfiRRq_keb4fHwLO8xJyRXbfK3Q7cscuQ@mail.gmail.com> Doing this probing inside of the Makefiles means we have a maze of ifdefs inside the source code and child Makefiles that need to make proper decisions on this too. Instead, we do it at Kconfig time, like many other compiler and assembler options, which allows us to set up the dependencies normally for full compilation units. This patchset might have weird implications, as things have relied on the old behavior for a long time. For example, it now means that environment changes need for Kconfig's defaults to be triggered again. I recently saw some patch on LKML that was doing a substring comparison on KBUILD_CFLAGS looking for -DCONFIG_AS_SOMETHING; things like that will have to change too. This RFC isn't super heavily tested, and I expect problems. Let me know what you think. Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> Cc: x86@kernel.org Cc: linux-crypto@vger.kernel.org Jason A. Donenfeld (3): x86: probe assembler instead of kconfig instead of makefile crypto: x86 - rework configuration based on Kconfig crypto: curve25519 - do not pollute dispatcher based on assembler arch/x86/Kconfig | 2 + arch/x86/Kconfig.assembler | 36 ++++++++ arch/x86/Makefile | 22 ----- arch/x86/crypto/Makefile | 162 ++++++++++++++-------------------- crypto/Kconfig | 28 +++--- drivers/gpu/drm/i915/Makefile | 3 - include/crypto/curve25519.h | 6 +- lib/raid6/test/Makefile | 9 -- 8 files changed, 120 insertions(+), 148 deletions(-) create mode 100644 arch/x86/Kconfig.assembler -- 2.25.1
next prev parent reply other threads:[~2020-03-21 0:50 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-16 8:49 [GIT PULL] Crypto Update for 5.4 Herbert Xu 2019-09-18 19:55 ` pr-tracker-bot 2019-09-23 5:05 ` [GIT PULL] Crypto Fixes " Herbert Xu 2019-09-23 16:50 ` pr-tracker-bot 2019-10-10 12:38 ` Herbert Xu 2019-10-10 15:45 ` pr-tracker-bot 2019-11-17 1:00 ` Herbert Xu 2019-11-17 2:35 ` pr-tracker-bot 2019-12-02 6:20 ` [GIT PULL] Crypto Fixes for 5.5 Herbert Xu 2019-12-03 1:30 ` pr-tracker-bot 2019-12-14 8:47 ` Herbert Xu 2019-12-14 22:05 ` pr-tracker-bot 2020-01-15 15:08 ` Herbert Xu 2020-01-15 19:35 ` pr-tracker-bot 2020-02-13 3:32 ` [GIT PULL] Crypto Fixes for 5.6 Herbert Xu 2020-02-13 22:40 ` pr-tracker-bot 2020-02-24 6:00 ` Herbert Xu 2020-02-24 20:25 ` pr-tracker-bot 2020-03-12 11:57 ` Herbert Xu 2020-03-12 16:40 ` Linus Torvalds 2020-03-13 5:27 ` Masahiro Yamada 2020-03-20 23:53 ` Jason A. Donenfeld 2020-03-21 15:43 ` Linus Torvalds 2020-03-21 0:49 ` Jason A. Donenfeld [this message] 2020-03-21 0:49 ` [PATCH RFC 1/3] x86: probe assembler instead of kconfig instead of makefile Jason A. Donenfeld 2020-03-21 0:49 ` [PATCH RFC 2/3] crypto: x86 - rework configuration based on Kconfig Jason A. Donenfeld 2020-03-21 0:49 ` [PATCH RFC 3/3] crypto: curve25519 - do not pollute dispatcher based on assembler Jason A. Donenfeld 2020-03-12 17:05 ` [GIT PULL] Crypto Fixes for 5.6 pr-tracker-bot 2020-03-23 22:54 ` Herbert Xu 2020-03-23 23:05 ` pr-tracker-bot 2020-04-08 6:15 ` [GIT PULL] Crypto Fixes for 5.7 Herbert Xu 2020-04-09 4:55 ` pr-tracker-bot 2020-04-29 5:54 ` Herbert Xu 2020-04-29 16:50 ` pr-tracker-bot 2020-05-06 5:10 ` Herbert Xu 2020-05-06 17:25 ` pr-tracker-bot 2020-06-11 4:05 ` [GIT PULL] Crypto Fixes for 5.8 Herbert Xu 2020-06-11 18:25 ` pr-tracker-bot 2020-06-21 8:23 ` Herbert Xu 2020-06-21 17:10 ` pr-tracker-bot 2020-06-29 2:16 ` Herbert Xu 2020-06-29 17:15 ` pr-tracker-bot 2020-08-14 13:18 ` [GIT PULL] Crypto Fixes for 5.9 Herbert Xu 2020-08-14 20:34 ` pr-tracker-bot 2019-11-25 3:45 ` [GIT PULL] Crypto Update for 5.5 Herbert Xu 2019-11-26 4:25 ` pr-tracker-bot 2020-01-28 5:03 ` [GIT PULL] Crypto Update for 5.6 Herbert Xu 2020-01-29 0:30 ` pr-tracker-bot 2020-04-01 4:27 ` [GIT PULL] Crypto Update for 5.7 Herbert Xu 2020-04-01 22:35 ` pr-tracker-bot 2020-06-01 2:45 ` [GIT PULL] Crypto Update for 5.8 Herbert Xu 2020-06-01 19:35 ` pr-tracker-bot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200321004945.451497-1-Jason@zx2c4.com \ --to=jason@zx2c4.com \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=torvalds@linux-foundation.org \ --cc=x86@kernel.org \ --cc=yamada.masahiro@socionext.com \ --subject='Re: [PATCH RFC 0/3] x86: probe for assembler capabilities in Kconfig' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).