From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0450C54FCE for ; Mon, 23 Mar 2020 16:38:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1AC320753 for ; Mon, 23 Mar 2020 16:38:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727411AbgCWQis (ORCPT ); Mon, 23 Mar 2020 12:38:48 -0400 Received: from mga12.intel.com ([192.55.52.136]:30481 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727234AbgCWQis (ORCPT ); Mon, 23 Mar 2020 12:38:48 -0400 IronPort-SDR: Rriv0Z8hJsGqsw3IoOkPAtgtiPO6JHB23PHs7p4zPBv+48a/GJlbM73vt8QMk6fMAwnqRW4mjh p3JleAiIVMMg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 09:38:46 -0700 IronPort-SDR: BNtv86v3w8JwvH4wJojnjAtNBR5zND3RBh/ddNAj1/0KWdAuOS7J1X36McxoHrFDWlrsVZa05+ xW30ri8rHyMA== X-IronPort-AV: E=Sophos;i="5.72,297,1580803200"; d="scan'208";a="269933222" Received: from smtp.ostc.intel.com ([10.54.29.231]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 09:38:45 -0700 Received: from localhost (mtg-dev.jf.intel.com [10.54.74.10]) by smtp.ostc.intel.com (Postfix) with ESMTP id E3150636B; Mon, 23 Mar 2020 16:38:43 +0000 (UTC) Date: Mon, 23 Mar 2020 09:38:44 -0700 From: mark gross To: Thomas Gleixner Cc: Andy Shevchenko , LKML , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Greg Kroah-Hartman , Tony Luck , "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Paolo Bonzini , Darren Hart , Andy Shevchenko , Viresh Kumar , Linux PM , Srinivas Pandruvada , linux-edac@vger.kernel.org, Platform Driver , Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org, Zhang Rui , Daniel Lezcano , Amit Kucheria , Chanwoo Choi , Jacob Pan , Adrian Hunter , Ulf Hansson , linux-mmc , Bjorn Helgaas , linux-pci@vger.kernel.org, Takashi Iwai , ALSA Development Mailing List , Herbert Xu , "David S. Miller" , linux-crypto Subject: Re: [patch 08/22] ACPI: Convert to new X86 CPU match macros Message-ID: <20200323163844.GB123290@mtg-dev.jf.intel.com> Reply-To: mgross@linux.intel.com References: <20200320131345.635023594@linutronix.de> <20200320131509.467730627@linutronix.de> <87bloqpy1x.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bloqpy1x.fsf@nanos.tec.linutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Mar 20, 2020 at 09:32:26PM +0100, Thomas Gleixner wrote: > Andy Shevchenko writes: > > > On Fri, Mar 20, 2020 at 3:19 PM Thomas Gleixner wrote: > >> > >> The new macro set has a consistent namespace and uses C99 initializers > >> instead of the grufty C89 ones. > >> > >> Rename the local macro wrapper to X86_MATCH for consistency. It stays for > >> readability sake. > > > >> + X86_MATCH_INTEL_FAM6_MODEL(ATOM_SILVERMONT, NULL), > >> + X86_MATCH_INTEL_FAM6_MODEL(ATOM_AIRMONT, NULL), > > > >> -#define ICPU(model) { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, } > >> +#define X86_MATCH(model) X86_MATCH_INTEL_FAM6_MODEL(model, NULL) > > > > Maybe we can do a generic macro to avoid all these ', NULL' repetitions? > > I opted for having the data argument everywhere to keep the macro maze > small. And we have enough places where data is actually used. +1 --mark > Thanks, > > tglx