From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84FDDC54FCE for ; Tue, 24 Mar 2020 11:56:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64C952080C for ; Tue, 24 Mar 2020 11:56:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727407AbgCXLz7 (ORCPT ); Tue, 24 Mar 2020 07:55:59 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:37400 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727416AbgCXLz7 (ORCPT ); Tue, 24 Mar 2020 07:55:59 -0400 Received: from gwarestrin.me.apana.org.au ([192.168.0.7] helo=gwarestrin.arnor.me.apana.org.au) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1jGi91-0005xF-TT; Tue, 24 Mar 2020 22:54:57 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Tue, 24 Mar 2020 22:54:55 +1100 Date: Tue, 24 Mar 2020 22:54:55 +1100 From: Herbert Xu To: Masahiro Yamada Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Linus Torvalds , Kees Cook , clang-built-linux@googlegroups.com, linux-crypto@vger.kernel.org, Ingo Molnar , Thomas Gleixner , Borislav Petkov , Peter Zijlstra , "H . Peter Anvin" , x86@kernel.org, linux-kbuild@vger.kernel.org, "Jason A. Donenfeld" Subject: Re: [PATCH 13/16] crypto: curve25519 - do not pollute dispatcher based on assembler Message-ID: <20200324115455.GB31003@gondor.apana.org.au> References: <20200324084821.29944-1-masahiroy@kernel.org> <20200324084821.29944-14-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324084821.29944-14-masahiroy@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Mar 24, 2020 at 05:48:18PM +0900, Masahiro Yamada wrote: > From: "Jason A. Donenfeld" > > Since we're doing a static inline dispatch here, we normally branch > based on whether or not there's an arch implementation. That would have > been fine in general, except the crypto Makefile prior used to turn > things off -- despite the Kconfig -- resulting in us needing to also > hard code various assembler things into the dispatcher too. The horror! > Now that the assembler config options are done by Kconfig, we can get > rid of the inconsistency. > > Signed-off-by: Jason A. Donenfeld > Signed-off-by: Masahiro Yamada > --- > > include/crypto/curve25519.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt