Linux-Crypto Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2] arm64: Make extension enablement consistent
@ 2020-03-25 13:55 Mark Brown
  2020-03-25 13:55 ` [PATCH 1/2] arm64: crypto: Consistently enable extension Mark Brown
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Mark Brown @ 2020-03-25 13:55 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon, Eric Biggers, Ard Biesheuvel
  Cc: linux-arm-kernel, linux-crypto, Mark Brown

Currently we use a mix of .arch and .cpu to enable architecture
extensions, make things consistent by converting the two instances of
.cpu to .arch which is more common and a bit more idiomatic for our
goal.

Mark Brown (2):
  arm64: crypto: Consistently enable extension
  arm64: lib: Consistently enable crc32 extension

 arch/arm64/crypto/crct10dif-ce-core.S | 2 +-
 arch/arm64/lib/crc32.S                | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] arm64: crypto: Consistently enable extension
  2020-03-25 13:55 [PATCH 0/2] arm64: Make extension enablement consistent Mark Brown
@ 2020-03-25 13:55 ` Mark Brown
  2020-03-25 13:55 ` [PATCH 2/2] arm64: lib: Consistently enable crc32 extension Mark Brown
  2020-03-25 16:00 ` [PATCH 0/2] arm64: Make extension enablement consistent Ard Biesheuvel
  2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2020-03-25 13:55 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon, Eric Biggers, Ard Biesheuvel
  Cc: linux-arm-kernel, linux-crypto, Mark Brown

Currently most of the crypto files enable the crypto extension using the
.arch directive but crct10dif-ce-core.S uses .cpu instead. Move that over
to .arch for consistency.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/crypto/crct10dif-ce-core.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/crypto/crct10dif-ce-core.S b/arch/arm64/crypto/crct10dif-ce-core.S
index 5a95c2628fbf..111d9c9abddd 100644
--- a/arch/arm64/crypto/crct10dif-ce-core.S
+++ b/arch/arm64/crypto/crct10dif-ce-core.S
@@ -66,7 +66,7 @@
 #include <asm/assembler.h>
 
 	.text
-	.cpu		generic+crypto
+	.arch		armv8-a+crypto
 
 	init_crc	.req	w19
 	buf		.req	x20
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: lib: Consistently enable crc32 extension
  2020-03-25 13:55 [PATCH 0/2] arm64: Make extension enablement consistent Mark Brown
  2020-03-25 13:55 ` [PATCH 1/2] arm64: crypto: Consistently enable extension Mark Brown
@ 2020-03-25 13:55 ` Mark Brown
  2020-03-25 16:00 ` [PATCH 0/2] arm64: Make extension enablement consistent Ard Biesheuvel
  2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2020-03-25 13:55 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon, Eric Biggers, Ard Biesheuvel
  Cc: linux-arm-kernel, linux-crypto, Mark Brown

Currently most of the assembly files that use architecture extensions
enable them using the .arch directive but crc32.S uses .cpu instead. Move
that over to .arch for consistency.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/lib/crc32.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/lib/crc32.S b/arch/arm64/lib/crc32.S
index 243e107e9896..0f9e10ecda23 100644
--- a/arch/arm64/lib/crc32.S
+++ b/arch/arm64/lib/crc32.S
@@ -9,7 +9,7 @@
 #include <asm/alternative.h>
 #include <asm/assembler.h>
 
-	.cpu		generic+crc
+	.arch		armv8-a+crc
 
 	.macro		__crc32, c
 	cmp		x2, #16
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] arm64: Make extension enablement consistent
  2020-03-25 13:55 [PATCH 0/2] arm64: Make extension enablement consistent Mark Brown
  2020-03-25 13:55 ` [PATCH 1/2] arm64: crypto: Consistently enable extension Mark Brown
  2020-03-25 13:55 ` [PATCH 2/2] arm64: lib: Consistently enable crc32 extension Mark Brown
@ 2020-03-25 16:00 ` Ard Biesheuvel
  2 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2020-03-25 16:00 UTC (permalink / raw)
  To: Mark Brown
  Cc: Catalin Marinas, Will Deacon, Eric Biggers, linux-arm-kernel,
	linux-crypto

On Wed, 25 Mar 2020 at 14:55, Mark Brown <broonie@kernel.org> wrote:
>
> Currently we use a mix of .arch and .cpu to enable architecture
> extensions, make things consistent by converting the two instances of
> .cpu to .arch which is more common and a bit more idiomatic for our
> goal.
>
> Mark Brown (2):
>   arm64: crypto: Consistently enable extension
>   arm64: lib: Consistently enable crc32 extension
>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

>  arch/arm64/crypto/crct10dif-ce-core.S | 2 +-
>  arch/arm64/lib/crc32.S                | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25 13:55 [PATCH 0/2] arm64: Make extension enablement consistent Mark Brown
2020-03-25 13:55 ` [PATCH 1/2] arm64: crypto: Consistently enable extension Mark Brown
2020-03-25 13:55 ` [PATCH 2/2] arm64: lib: Consistently enable crc32 extension Mark Brown
2020-03-25 16:00 ` [PATCH 0/2] arm64: Make extension enablement consistent Ard Biesheuvel

Linux-Crypto Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-crypto/0 linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ https://lore.kernel.org/linux-crypto \
		linux-crypto@vger.kernel.org
	public-inbox-index linux-crypto

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-crypto


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git