From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-crypto@vger.kernel.org,
Emil Renner Berthing <kernel@esmil.dk>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH crypto] crypto: arm[64]/poly1305 - add artifact to .gitignore files
Date: Fri, 27 Mar 2020 15:55:44 +1100 [thread overview]
Message-ID: <20200327045543.GA19982@gondor.apana.org.au> (raw)
In-Reply-To: <20200319180114.6437-1-Jason@zx2c4.com>
On Thu, Mar 19, 2020 at 12:01:14PM -0600, Jason A. Donenfeld wrote:
> The .S_shipped yields a .S, and the pattern in these directories is to
> add that to .gitignore so that git-status doesn't raise a fuss.
>
> Fixes: a6b803b3ddc7 ("crypto: arm/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> Reported-by: Emil Renner Berthing <kernel@esmil.dk>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> arch/arm/crypto/.gitignore | 1 +
> arch/arm64/crypto/.gitignore | 1 +
> 2 files changed, 2 insertions(+)
Patch applied.
> diff --git a/arch/arm64/crypto/.gitignore b/arch/arm64/crypto/.gitignore
> index 879df8781ed5..e403b1343328 100644
> --- a/arch/arm64/crypto/.gitignore
> +++ b/arch/arm64/crypto/.gitignore
> @@ -1,2 +1,3 @@
> sha256-core.S
> sha512-core.S
> +poly1305-core.S
This didn't apply because a similar patch had already been added
to cryptodev a month ago. Please base your patches on the latest
cryptodev in future.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-03-27 4:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 18:01 [PATCH crypto] crypto: arm[64]/poly1305 - add artifact to .gitignore files Jason A. Donenfeld
2020-03-26 4:32 ` Jason A. Donenfeld
2020-03-26 4:38 ` Herbert Xu
2020-03-26 4:39 ` Jason A. Donenfeld
2020-03-27 4:55 ` Herbert Xu [this message]
2020-03-27 4:57 ` Jason A. Donenfeld
2020-03-27 11:03 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327045543.GA19982@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=kernel@esmil.dk \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).