linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH v1 14/50] crypto/testmgr.c: use prandom_u32_max() & prandom_bytes()
@ 2019-11-29 20:24 George Spelvin
  0 siblings, 0 replies; only message in thread
From: George Spelvin @ 2019-11-29 20:24 UTC (permalink / raw)
  To: linux-kernel, lkml; +Cc: Herbert Xu, linux-crypto

...in a couple of places where they're appropriate.

There are many other places where successive code blocks make calls
like prandom_u32() % 2 followed immediately by prandom_u32() % 4.
This could be easily written to use three bits of one call, but
at some cost in clarity and obvious-correctness, which is more
important that efficiency in self-test code.

Signed-off-by: George Spelvin <lkml@sdf.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org
---
 crypto/testmgr.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index e8f21f7348a48..bc9252768bdba 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -770,7 +770,7 @@ static void mutate_buffer(u8 *buf, size_t count)
 	if (prandom_u32() % 4 == 0) {
 		num_flips = min_t(size_t, 1 << (prandom_u32() % 8), count * 8);
 		for (i = 0; i < num_flips; i++) {
-			pos = prandom_u32() % (count * 8);
+			pos = prandom_u32_max(count * 8);
 			buf[pos / 8] ^= 1 << (pos % 8);
 		}
 	}
@@ -821,8 +821,7 @@ static void generate_random_bytes(u8 *buf, size_t count)
 		break;
 	default:
 		/* Fully random bytes */
-		for (i = 0; i < count; i++)
-			buf[i] = (u8)prandom_u32();
+		prandom_bytes(buf, count);
 	}
 }
 
-- 
2.26.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-03-28 16:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-29 20:24 [RFC PATCH v1 14/50] crypto/testmgr.c: use prandom_u32_max() & prandom_bytes() George Spelvin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).