* [PATCH net] crypto: chtls - Fix build error without IPV6
@ 2020-04-02 1:43 YueHaibing
2020-04-02 13:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-04-02 1:43 UTC (permalink / raw)
To: ayush.sawal, vinay.yadav, rohitm, herbert, davem
Cc: linux-crypto, linux-kernel, netdev, YueHaibing
If IPV6 is not set, build fails:
drivers/crypto/chelsio/chcr_ktls.c: In function ‘chcr_ktls_act_open_req6’:
./include/net/sock.h:380:37: error: ‘struct sock_common’ has no member named ‘skc_v6_rcv_saddr’; did you mean ‘skc_rcv_saddr’?
#define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
^
drivers/crypto/chelsio/chcr_ktls.c:258:37: note: in expansion of macro ‘sk_v6_rcv_saddr’
cpl->local_ip_hi = *(__be64 *)&sk->sk_v6_rcv_saddr.in6_u.u6_addr8[0];
^~~~~~~~~~~~~~~
Add IPV6 dependency to fix this.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 62370a4f346d ("cxgb4/chcr: Add ipv6 support and statistics")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/crypto/chelsio/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/chelsio/Kconfig b/drivers/crypto/chelsio/Kconfig
index f2756836093f..7bf1d8152a5d 100644
--- a/drivers/crypto/chelsio/Kconfig
+++ b/drivers/crypto/chelsio/Kconfig
@@ -47,6 +47,7 @@ config CHELSIO_TLS_DEVICE
bool "Chelsio Inline KTLS Offload"
depends on CHELSIO_T4
depends on TLS_DEVICE
+ depends on IPV6
select CRYPTO_DEV_CHELSIO
default y
help
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] crypto: chtls - Fix build error without IPV6
2020-04-02 1:43 [PATCH net] crypto: chtls - Fix build error without IPV6 YueHaibing
@ 2020-04-02 13:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-04-02 13:54 UTC (permalink / raw)
To: yuehaibing
Cc: ayush.sawal, vinay.yadav, rohitm, herbert, linux-crypto,
linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 2 Apr 2020 09:43:23 +0800
> If IPV6 is not set, build fails:
>
> drivers/crypto/chelsio/chcr_ktls.c: In function ‘chcr_ktls_act_open_req6’:
> ./include/net/sock.h:380:37: error: ‘struct sock_common’ has no member named ‘skc_v6_rcv_saddr’; did you mean ‘skc_rcv_saddr’?
> #define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
> ^
> drivers/crypto/chelsio/chcr_ktls.c:258:37: note: in expansion of macro ‘sk_v6_rcv_saddr’
> cpl->local_ip_hi = *(__be64 *)&sk->sk_v6_rcv_saddr.in6_u.u6_addr8[0];
> ^~~~~~~~~~~~~~~
>
> Add IPV6 dependency to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 62370a4f346d ("cxgb4/chcr: Add ipv6 support and statistics")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
This is a hard hammer, and I think proper CPP testing should be added to the
driver code instead.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-02 13:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02 1:43 [PATCH net] crypto: chtls - Fix build error without IPV6 YueHaibing
2020-04-02 13:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).