linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: davem@davemloft.net, mripard@kernel.org, wens@csie.org,
	linux-arm-kernel@lists.infradead.org,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sunxi@googlegroups.com
Subject: Re: [PATCH 1/7] crypto: rng - add missing __crypto_rng_cast to the rng header
Date: Thu, 16 Apr 2020 16:06:41 +1000	[thread overview]
Message-ID: <20200416060640.GA19267@gondor.apana.org.au> (raw)
In-Reply-To: <1585943438-862-2-git-send-email-clabbe@baylibre.com>

On Fri, Apr 03, 2020 at 07:50:32PM +0000, Corentin Labbe wrote:
> This patch add __crypto_rng_cast() to the rng header like other
> __algo_cast functions.
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
>  include/crypto/rng.h | 5 +++++
>  1 file changed, 5 insertions(+)

This should never be exported.  Either change the driver to use
use crypto_tfm_ctx instead of crypto_rng_ctx, or if you have the
time please convert the rng API over to the new way of doing things
like aead/skcipher.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2020-04-16  6:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-03 19:50 [PATCH 0/7] crypto: sun8i-ss: support PRNG and hashes Corentin Labbe
2020-04-03 19:50 ` [PATCH 1/7] crypto: rng - add missing __crypto_rng_cast to the rng header Corentin Labbe
2020-04-16  6:06   ` Herbert Xu [this message]
2020-04-03 19:50 ` [PATCH 2/7] crypto: sun8i-ss: Add SS_START define Corentin Labbe
2020-04-03 19:50 ` [PATCH 3/7] crypto: sun8i-ss: Add support for the PRNG Corentin Labbe
2020-04-03 19:50 ` [PATCH 4/7] crypto: sun8i-ss: support hash algorithms Corentin Labbe
2020-04-03 19:50 ` [PATCH 5/7] crypto: sun8i-ss: fix a trivial typo Corentin Labbe
2020-04-03 19:50 ` [PATCH 6/7] crypto: sun8i-ss: Add more comment on some structures Corentin Labbe
2020-04-03 19:50 ` [PATCH 7/7] crypto: sun8i-ss: better debug printing Corentin Labbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200416060640.GA19267@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=clabbe@baylibre.com \
    --cc=davem@davemloft.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mripard@kernel.org \
    --cc=wens@csie.org \
    --subject='Re: [PATCH 1/7] crypto: rng - add missing __crypto_rng_cast to the rng header' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).