* [PATCH] crypto: sun8i-ss - Delete an error message in sun8i_ss_probe()
@ 2020-04-04 15:45 Markus Elfring
2020-04-05 17:56 ` Corentin Labbe
2020-04-16 6:51 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Markus Elfring @ 2020-04-04 15:45 UTC (permalink / raw)
To: linux-crypto, linux-arm-kernel, Chen-Yu Tsai, Colin Ian King,
Corentin Labbe, David S. Miller, Herbert Xu, Maxime Ripard
Cc: LKML, kernel-janitors, Tang Bin
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 4 Apr 2020 17:34:53 +0200
The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
index 6b301afffd11..a1fb2fbdbe7b 100644
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
@@ -537,10 +537,8 @@ static int sun8i_ss_probe(struct platform_device *pdev)
return err;
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(ss->dev, "Cannot get SecuritySystem IRQ\n");
+ if (irq < 0)
return irq;
- }
ss->reset = devm_reset_control_get(&pdev->dev, NULL);
if (IS_ERR(ss->reset)) {
--
2.26.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: sun8i-ss - Delete an error message in sun8i_ss_probe()
2020-04-04 15:45 [PATCH] crypto: sun8i-ss - Delete an error message in sun8i_ss_probe() Markus Elfring
@ 2020-04-05 17:56 ` Corentin Labbe
2020-04-16 6:51 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Corentin Labbe @ 2020-04-05 17:56 UTC (permalink / raw)
To: Markus Elfring
Cc: linux-crypto, linux-arm-kernel, Chen-Yu Tsai, Colin Ian King,
David S. Miller, Herbert Xu, Maxime Ripard, LKML,
kernel-janitors, Tang Bin
On Sat, Apr 04, 2020 at 05:45:26PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 4 Apr 2020 17:34:53 +0200
>
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> index 6b301afffd11..a1fb2fbdbe7b 100644
> --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> @@ -537,10 +537,8 @@ static int sun8i_ss_probe(struct platform_device *pdev)
> return err;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(ss->dev, "Cannot get SecuritySystem IRQ\n");
> + if (irq < 0)
> return irq;
> - }
>
> ss->reset = devm_reset_control_get(&pdev->dev, NULL);
> if (IS_ERR(ss->reset)) {
> --
> 2.26.0
>
Hello
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: sun8i-ss - Delete an error message in sun8i_ss_probe()
2020-04-04 15:45 [PATCH] crypto: sun8i-ss - Delete an error message in sun8i_ss_probe() Markus Elfring
2020-04-05 17:56 ` Corentin Labbe
@ 2020-04-16 6:51 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2020-04-16 6:51 UTC (permalink / raw)
To: Markus Elfring
Cc: linux-crypto, linux-arm-kernel, Chen-Yu Tsai, Colin Ian King,
Corentin Labbe, David S. Miller, Maxime Ripard, LKML,
kernel-janitors, Tang Bin
On Sat, Apr 04, 2020 at 05:45:26PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 4 Apr 2020 17:34:53 +0200
>
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-16 6:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-04 15:45 [PATCH] crypto: sun8i-ss - Delete an error message in sun8i_ss_probe() Markus Elfring
2020-04-05 17:56 ` Corentin Labbe
2020-04-16 6:51 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).