From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Linux Crypto List <linux-crypto@vger.kernel.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Shukun Tan <tanshukun1@huawei.com>,
Zhou Wang <wangzhou1@hisilicon.com>,
Zaibo Xu <xuzaibo@huawei.com>
Subject: linux-next: build failure after merge of the crypto tree
Date: Tue, 21 Apr 2020 15:12:40 +1000 [thread overview]
Message-ID: <20200421151240.4dfc679a@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 3041 bytes --]
Hi all,
After merging the crypto tree, today's linux-next build (powerpc
allyesconfig) failed like this:
WARNING: unmet direct dependencies detected for CRYPTO_DEV_HISI_QM
Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && (ARM64 || COMPILE_TEST [=y]) && PCI [=y] && PCI_MSI [=y] && (UACCE [=y] || UACCE [=y]=n) && ACPI
Selected by [y]:
- CRYPTO_DEV_HISI_SEC2 [=y] && CRYPTO [=y] && CRYPTO_HW [=y] && PCI [=y] && PCI_MSI [=y] && (UACCE [=y] || UACCE [=y]=n) && (ARM64 || COMPILE_TEST [=y] && 64BIT [=y])
- CRYPTO_DEV_HISI_ZIP [=y] && CRYPTO [=y] && CRYPTO_HW [=y] && PCI [=y] && PCI_MSI [=y] && (ARM64 || COMPILE_TEST [=y] && 64BIT [=y]) && (!CPU_BIG_ENDIAN [=y] || COMPILE_TEST [=y]) && (UACCE [=y] || UACCE [=y]=n)
- CRYPTO_DEV_HISI_HPRE [=y] && CRYPTO [=y] && CRYPTO_HW [=y] && PCI [=y] && PCI_MSI [=y] && (UACCE [=y] || UACCE [=y]=n) && (ARM64 || COMPILE_TEST [=y] && 64BIT [=y])
drivers/crypto/hisilicon/qm.c: In function 'qm_soft_reset':
drivers/crypto/hisilicon/qm.c:2915:7: error: implicit declaration of function 'acpi_evaluate_integer'; did you mean 'acpi_evaluate_object'? [-Werror=implicit-function-declaration]
2915 | s = acpi_evaluate_integer(ACPI_HANDLE(&pdev->dev),
| ^~~~~~~~~~~~~~~~~~~~~
| acpi_evaluate_object
Caused by commit
6c6dd5802c2d ("crypto: hisilicon/qm - add controller reset interface")
Unfortunately not fixed by commit
f88480e300ac ("crypto: hisilicon/qm - fix build failure with ACPI off")
[the moral is "don't select symbols that have dependencies" :-( ]
I have added the following patch for today
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 21 Apr 2020 14:56:49 +1000
Subject: [PATCH] crypto: hisilicon/qm add more ACPI dependencies
due to the selects of CRYPTO_DEV_HISI_QM which now depends on ACPI
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/crypto/hisilicon/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
index 99e962e39f36..9c3b3ca815e6 100644
--- a/drivers/crypto/hisilicon/Kconfig
+++ b/drivers/crypto/hisilicon/Kconfig
@@ -29,6 +29,7 @@ config CRYPTO_DEV_HISI_SEC2
depends on PCI && PCI_MSI
depends on UACCE || UACCE=n
depends on ARM64 || (COMPILE_TEST && 64BIT)
+ depends on ACPI
help
Support for HiSilicon SEC Engine of version 2 in crypto subsystem.
It provides AES, SM4, and 3DES algorithms with ECB
@@ -53,6 +54,7 @@ config CRYPTO_DEV_HISI_ZIP
depends on ARM64 || (COMPILE_TEST && 64BIT)
depends on !CPU_BIG_ENDIAN || COMPILE_TEST
depends on UACCE || UACCE=n
+ depends on ACPI
select CRYPTO_DEV_HISI_QM
help
Support for HiSilicon ZIP Driver
@@ -62,6 +64,7 @@ config CRYPTO_DEV_HISI_HPRE
depends on PCI && PCI_MSI
depends on UACCE || UACCE=n
depends on ARM64 || (COMPILE_TEST && 64BIT)
+ depends on ACPI
select CRYPTO_DEV_HISI_QM
select CRYPTO_DH
select CRYPTO_RSA
--
2.25.1
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2020-04-21 5:12 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 5:12 Stephen Rothwell [this message]
2020-04-22 13:33 ` linux-next: build failure after merge of the crypto tree Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2024-03-13 0:57 Stephen Rothwell
2024-03-13 1:43 ` Herbert Xu
2024-03-13 1:45 ` Herbert Xu
2024-03-13 1:58 ` Barry Song
2024-03-13 2:01 ` Eric Biggers
2024-03-13 2:04 ` Herbert Xu
2024-03-13 2:29 ` Eric Biggers
2024-03-13 2:36 ` Herbert Xu
2024-03-13 2:12 ` Barry Song
2024-03-13 2:22 ` Eric Biggers
2023-10-30 4:58 Stephen Rothwell
2023-10-30 5:09 ` Stephen Rothwell
2023-10-30 5:23 ` Herbert Xu
2023-10-30 17:44 ` Dmitry Safonov
2023-10-30 22:02 ` Jakub Kicinski
2023-10-31 4:51 ` Eric Biggers
2023-10-31 20:14 ` Jakub Kicinski
2023-06-26 2:39 Stephen Rothwell
2023-06-26 10:20 ` Herbert Xu
2023-05-22 0:52 Stephen Rothwell
2023-05-22 5:15 ` Herbert Xu
2023-05-23 0:36 ` Stephen Rothwell
2023-04-11 0:48 Stephen Rothwell
2023-04-11 2:22 ` Herbert Xu
2023-01-17 3:47 Stephen Rothwell
2023-01-16 0:29 Stephen Rothwell
2022-12-04 23:48 Stephen Rothwell
2022-12-04 23:52 ` Stephen Rothwell
2022-09-07 1:53 Stephen Rothwell
2022-09-06 1:30 Stephen Rothwell
2022-05-09 11:10 Stephen Rothwell
2022-05-09 12:26 ` Masahiro Yamada
2021-09-27 4:32 Stephen Rothwell
2020-04-17 3:40 Stephen Rothwell
2020-04-17 4:00 ` Shukun Tan
2019-08-12 3:21 Stephen Rothwell
2019-08-12 6:53 ` Zhou Wang
[not found] <20161129115529.41f9f0b5@canb.auug.org.au>
2016-11-29 7:08 ` Herbert Xu
[not found] ` <20161129070840.GA5113@gondor.apana.org.au>
[not found] ` <DB4PR04MB084718B8EB90B061EA144C02988D0@DB4PR04MB0847.eurprd04.prod.outlook.com>
2016-11-29 8:43 ` Herbert Xu
[not found] <20160720174634.53bad636@canb.auug.org.au>
2016-07-20 14:32 ` Herbert Xu
2016-06-24 6:20 Stephen Rothwell
[not found] <20150317130104.548124c2@canb.auug.org.au>
2015-03-17 11:11 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421151240.4dfc679a@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=tanshukun1@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).