linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<linux-crypto@vger.kernel.org>
Subject: [PATCHv2 0/7] crypto: TI SA2UL crypto accelerator support
Date: Fri, 24 Apr 2020 19:44:23 +0300	[thread overview]
Message-ID: <20200424164430.3288-1-t-kristo@ti.com> (raw)

Hi,

This is 2nd revision of the series [1] Keerthy posted quite a while back,
I've sort of adopted the series for now. Compared to v1, there has been
pretty major re-design I've done across the driver to fix any review
comments, fix any bugs I've encountered, and get the full crypto
self-test suite working with the driver, including the extra tests.
I've also tested the driver with tcrypt and IPSec suite just to root out
any issues. This series applies on top of 5.7-rc1 also and has no
dependencies. The DTS patches are provided for reference here only, and
should be merged separately via ARM SoC tree once the driver is ready.

There is maybe one aspect of the driver I am somewhat uncertain myself,
and that is the init/update/final handling with the hash algorithm
support, or the caching part of it actually. If someone calls the device
with init+update sequences never finalizing the data, we end up with
memory leaks. Any thoughts on that how to handle it? I could maybe add
some timeout to purge stale buffers or alternatively just drop to SW
fallback completely for non-digest type hashing, but that would prevent
openssl/devcrypto from using the crypto accelerator completely; it uses
init+update+final sequence heavily.

-Tero

[1] https://patchwork.kernel.org/cover/11021337/


--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

             reply	other threads:[~2020-04-24 16:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 16:44 Tero Kristo [this message]
2020-04-24 16:44 ` [PATCHv2 1/7] dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation Tero Kristo
2020-05-11 21:53   ` Rob Herring
2020-05-12  4:47     ` Tero Kristo
2020-05-14 12:50     ` [PATCHv3 " Tero Kristo
2020-05-26 13:16       ` Tero Kristo
2020-05-28 15:23       ` Rob Herring
2020-06-03 10:01         ` Tero Kristo
2020-06-03 12:27           ` Herbert Xu
2020-06-03 12:38             ` Tero Kristo
2020-06-03 12:39               ` Herbert Xu
2020-06-03 12:53                 ` Tero Kristo
2020-06-03 12:54                   ` Herbert Xu
2020-04-24 16:44 ` [PATCHv2 2/7] crypto: sa2ul: Add crypto driver Tero Kristo
2020-04-24 16:44 ` [PATCHv2 3/7] crypto: sa2ul: add sha1/sha256/sha512 support Tero Kristo
2020-04-24 16:44 ` [PATCHv2 4/7] crypto: sa2ul: Add AEAD algorithm support Tero Kristo
2020-04-24 16:44 ` [PATCHv2 5/7] crypto: sa2ul: add device links to child devices Tero Kristo
2020-04-24 16:44 ` [PATCHv2 6/7] arm64: dts: ti: k3-am6: Add crypto accelarator node Tero Kristo
2020-04-24 16:44 ` [PATCHv2 7/7] arm64: dts: ti: k3-j721e-main: Add crypto accelerator node Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200424164430.3288-1-t-kristo@ti.com \
    --to=t-kristo@ti.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).