From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E94D3C47253 for ; Thu, 30 Apr 2020 14:10:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D32E8206D9 for ; Thu, 30 Apr 2020 14:10:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728096AbgD3OKu (ORCPT ); Thu, 30 Apr 2020 10:10:50 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:60848 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728643AbgD3OKt (ORCPT ); Thu, 30 Apr 2020 10:10:49 -0400 Received: from gwarestrin.me.apana.org.au ([192.168.0.7] helo=gwarestrin.arnor.me.apana.org.au) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1jU9s8-0000qz-47; Fri, 01 May 2020 00:09:05 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 01 May 2020 00:10:11 +1000 Date: Fri, 1 May 2020 00:10:11 +1000 From: Herbert Xu To: Hadar Gat Cc: Matt Mackall , Arnd Bergmann , Greg Kroah-Hartman , Krzysztof Kozlowski , Stefan Wahren , Zaibo Xu , Tomer Maimon , Randy Dunlap , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Gilad Ben-Yossef , Ofir Drang , nd Subject: Re: [PATCH v3 1/3] hwrng: cctrng - Add dependency on OF Message-ID: <20200430141011.GA13992@gondor.apana.org.au> References: <1587987364-4566-1-git-send-email-hadar.gat@arm.com> <1587987364-4566-2-git-send-email-hadar.gat@arm.com> <20200427150658.GA26305@gondor.apana.org.au> <20200428123007.GA3969@gondor.apana.org.au> <20200430074941.GA12529@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Apr 30, 2020 at 08:26:00AM +0000, Hadar Gat wrote: > > I don't understand if anything need to be fixed before this patch can be applied. > The patch adds dependency on OF, which was missing and is required for the cctrng driver. > (Indeed cctrng compilation passed also without CONFIG_OF because of the empty implementation of of_property_read*() functions that simply returns -ENOSYS.) Nevermind, I already have the CONFIG_OF flag on in my build test so it shouldn't be a problem. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt