From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: davem@davemloft.net, ebiggers@kernel.org, ebiggers@google.com,
pvanleeuwen@rambus.com, zohar@linux.ibm.com, gilad@benyossef.com,
jarkko.sakkinen@linux.intel.com, dmitry.kasatkin@intel.com,
nicstange@gmail.com, tadeusz.struk@intel.com, jmorris@namei.org,
serge@hallyn.com, zhang.jia@linux.alibaba.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/7] crpyto: introduce OSCCA certificate and SM2 asymmetric algorithm
Date: Fri, 29 May 2020 21:52:22 +1000 [thread overview]
Message-ID: <20200529115222.GB3573@gondor.apana.org.au> (raw)
In-Reply-To: <fba669ef-b784-bdd9-d34e-a7726df7342c@linux.alibaba.com>
On Fri, May 29, 2020 at 07:04:48PM +0800, Tianjia Zhang wrote:
>
> On 2020/4/16 14:01, Herbert Xu wrote:
> > On Thu, Apr 02, 2020 at 08:34:57PM +0800, Tianjia Zhang wrote:
> > > Hello all,
> > >
> > > This new module implement the OSCCA certificate and SM2 public key
> > > algorithm. It was published by State Encryption Management Bureau, China.
> > > List of specifications for OSCCA certificate and SM2 elliptic curve
> > > public key cryptography:
> > >
> > > * GM/T 0003.1-2012
> > > * GM/T 0003.2-2012
> > > * GM/T 0003.3-2012
> > > * GM/T 0003.4-2012
> > > * GM/T 0003.5-2012
> > > * GM/T 0015-2012
> > > * GM/T 0009-2012
> > >
> > > IETF: https://tools.ietf.org/html/draft-shen-sm2-ecdsa-02
> > > oscca: http://www.oscca.gov.cn/sca/xxgk/2010-12/17/content_1002386.shtml
> > > scctc: http://www.gmbz.org.cn/main/bzlb.html
> > >
> > > These patchs add the OID object identifier defined by OSCCA. The
> > > x509 certificate supports sm2-with-sm3 type certificate parsing
> > > and verification.
> >
> > I don't have any objections to the crypto API bits, but obviously
> > this is contingent on the x509 bits getting accepted since that's
> > the only in-kernel user. So can I see some acks on that please?
>
> Any opinion on this series patches? Do I need to provide additional
> information ?
As I said I need acks for the patches outside of the crypto API.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-05-29 11:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 12:34 [PATCH v2 0/7] crpyto: introduce OSCCA certificate and SM2 asymmetric algorithm Tianjia Zhang
2020-04-02 12:34 ` [PATCH v2 1/7] crypto: sm3 - export crypto_sm3_final function Tianjia Zhang
2020-04-02 12:34 ` [PATCH v2 2/7] lib/mpi: Extend the MPI library Tianjia Zhang
2020-04-02 12:35 ` [PATCH v2 3/7] lib/mpi: Introduce ec implementation to " Tianjia Zhang
2020-04-02 12:35 ` [PATCH v2 4/7] crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm Tianjia Zhang
2020-04-02 12:35 ` [PATCH v2 5/7] crypto: testmgr - support test with different ciphertext per encryption Tianjia Zhang
2020-04-02 12:35 ` [PATCH v2 6/7] X.509: support OSCCA certificate parse Tianjia Zhang
2020-04-02 12:35 ` [PATCH v2 7/7] X.509: support OSCCA sm2-with-sm3 certificate verification Tianjia Zhang
2020-04-16 6:01 ` [PATCH v2 0/7] crpyto: introduce OSCCA certificate and SM2 asymmetric algorithm Herbert Xu
2020-04-16 6:37 ` Tianjia Zhang
2020-05-29 11:04 ` Tianjia Zhang
2020-05-29 11:52 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529115222.GB3573@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=dmitry.kasatkin@intel.com \
--cc=ebiggers@google.com \
--cc=ebiggers@kernel.org \
--cc=gilad@benyossef.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicstange@gmail.com \
--cc=pvanleeuwen@rambus.com \
--cc=serge@hallyn.com \
--cc=tadeusz.struk@intel.com \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=zhang.jia@linux.alibaba.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).