From: Herbert Xu <herbert@gondor.apana.org.au>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
Mike Snitzer <msnitzer@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Milan Broz <mbroz@redhat.com>,
djeffery@redhat.com, dm-devel@redhat.com, qat-linux@intel.com,
linux-crypto@vger.kernel.org, guazhang@redhat.com,
jpittman@redhat.com
Subject: Re: [PATCH 1/4] qat: fix misunderstood -EBUSY return code
Date: Wed, 3 Jun 2020 22:25:38 +1000 [thread overview]
Message-ID: <20200603122537.GA31719@gondor.apana.org.au> (raw)
In-Reply-To: <alpine.LRH.2.02.2006030409520.15292@file01.intranet.prod.int.rdu2.redhat.com>
On Wed, Jun 03, 2020 at 04:31:54AM -0400, Mikulas Patocka wrote:
>
> > Should we just retry a number of times and then fail?
>
> It's better to get stuck in an infinite loop than to cause random I/O
> errors. The infinite loop requires reboot, but it doesn't damage data on
> disks.
>
> The proper solution would be to add the request to a queue and process the
> queue when some other request ended - but it would need substantial
> rewrite of the driver. Do you want to rewrite it using a queue?
>
> > Or, should we just move to the crypto-engine?
>
> What do you mean by the crypto-engine?
crypto-engine is the generic queueing mechanism that any crypto
driver can use to implement the queueing.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-06-03 12:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 16:03 [PATCH 1/4] qat: fix misunderstood -EBUSY return code Mikulas Patocka
2020-06-02 22:05 ` Giovanni Cabiddu
2020-06-03 8:31 ` Mikulas Patocka
2020-06-03 12:25 ` Herbert Xu [this message]
2020-06-03 16:55 ` Giovanni Cabiddu
2020-06-03 19:54 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603122537.GA31719@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=djeffery@redhat.com \
--cc=dm-devel@redhat.com \
--cc=giovanni.cabiddu@intel.com \
--cc=guazhang@redhat.com \
--cc=jpittman@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=mbroz@redhat.com \
--cc=mpatocka@redhat.com \
--cc=msnitzer@redhat.com \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).