From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Stephan Müller" <smueller@chronox.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
syzbot <syzbot+2e635807decef724a1fa@syzkaller.appspotmail.com>,
Eric Biggers <ebiggers@kernel.org>
Subject: Re: [PATCH v3] crypto: DRBG - always try to free Jitter RNG instance
Date: Fri, 12 Jun 2020 16:49:35 +1000 [thread overview]
Message-ID: <20200612064935.GF16987@gondor.apana.org.au> (raw)
In-Reply-To: <4563687.31r3eYUQgx@positron.chronox.de>
On Sun, Jun 07, 2020 at 03:20:26PM +0200, Stephan Müller wrote:
> The Jitter RNG is unconditionally allocated as a seed source follwoing
> the patch 97f2650e5040. Thus, the instance must always be deallocated.
>
> Reported-by: syzbot+2e635807decef724a1fa@syzkaller.appspotmail.com
> Fixes: 97f2650e5040 ("crypto: drbg - always seeded with SP800-90B ...")
> Signed-off-by: Stephan Mueller <smueller@chronox.de>
> ---
> crypto/drbg.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-06-12 6:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 3:41 memory leak in crypto_create_tfm syzbot
2020-06-03 3:55 ` Eric Biggers
2020-06-03 8:08 ` [PATCH] crypto: DRBG - always try to free Jitter RNG instance Stephan Müller
2020-06-03 11:09 ` Dan Carpenter
2020-06-03 11:40 ` Stephan Mueller
2020-06-04 6:41 ` [PATCH v2] " Stephan Müller
2020-06-05 0:43 ` Eric Biggers
2020-06-05 5:58 ` Stephan Mueller
2020-06-05 6:16 ` Eric Biggers
2020-06-05 6:52 ` Stephan Mueller
2020-06-05 16:21 ` Eric Biggers
2020-06-07 13:07 ` Stephan Müller
2020-06-07 13:20 ` [PATCH v3] " Stephan Müller
2020-06-12 6:49 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612064935.GF16987@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smueller@chronox.de \
--cc=syzbot+2e635807decef724a1fa@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).