From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 904E9C433E0 for ; Fri, 12 Jun 2020 12:16:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70BF920792 for ; Fri, 12 Jun 2020 12:16:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726089AbgFLMQz (ORCPT ); Fri, 12 Jun 2020 08:16:55 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:39514 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726053AbgFLMQy (ORCPT ); Fri, 12 Jun 2020 08:16:54 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jjic7-0005J9-J5; Fri, 12 Jun 2020 22:16:52 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 12 Jun 2020 22:16:51 +1000 Date: Fri, 12 Jun 2020 22:16:51 +1000 From: Herbert Xu To: Stephan Mueller Cc: Ard Biesheuvel , Linux Crypto Mailing List , Eric Biggers Subject: Re: [PATCH 1/3] crypto: skcipher - Add final chunk size field for chaining Message-ID: <20200612121651.GA15849@gondor.apana.org.au> References: <20200612120643.GA15724@gondor.apana.org.au> <1688262.LSb4nGpegl@tauon.chronox.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1688262.LSb4nGpegl@tauon.chronox.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Jun 12, 2020 at 02:15:52PM +0200, Stephan Mueller wrote: > > > +static inline unsigned int crypto_skcipher_fcsize( > > + struct crypto_skcipher *tfm) > > +{ > > + return crypto_skcipher_alg_fcsize(crypto_skcipher_alg(tfm)); > > Don't we have an implicit signedness conversion here? int -> unsigned int? Good catch. It's supposed to be int. Let me fix this. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt