From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ard Biesheuvel <ardb@kernel.org>,
Stephan Mueller <smueller@chronox.de>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [v2 PATCH 0/3] crypto: skcipher - Add support for no chaining and partial chaining
Date: Tue, 16 Jun 2020 09:53:54 -0700 [thread overview]
Message-ID: <20200616165354.GB40729@gmail.com> (raw)
In-Reply-To: <20200616110444.GA31608@gondor.apana.org.au>
On Tue, Jun 16, 2020 at 09:04:44PM +1000, Herbert Xu wrote:
> On Mon, Jun 15, 2020 at 11:50:28AM -0700, Eric Biggers wrote:
> >
> > Wouldn't it make a lot more sense to make skcipher algorithms non-chainable by
> > default, and only opt-in the ones where chaining is actually working? At the
> > moment we only test iv_out for CBC and CTR, so we can expect that all the others
> > are broken.
>
> Yes, I'm working through all the algorithms marking them. If it
> turns out that defaulting to off would result in a smaller patch
> then I'm certainly going to do that.
>
> > Note that wide-block modes such as Adiantum don't support chaining either.
> >
> > Also, please use a better name than "fcsize".
>
> Any suggestions?
>
Just spelling it out as final_chunksize would be much clearer.
But maybe there's a better name.
- Eric
next prev parent reply other threads:[~2020-06-16 16:53 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 19:02 [RFC/RFT PATCH 0/2] crypto: add CTS output IVs for arm64 and testmgr Ard Biesheuvel
2020-05-19 19:02 ` [RFC/RFT PATCH 1/2] crypto: arm64/aes - align output IV with generic CBC-CTS driver Ard Biesheuvel
2020-05-19 19:02 ` [RFC/RFT PATCH 2/2] crypto: testmgr - add output IVs for AES-CBC with ciphertext stealing Ard Biesheuvel
2020-05-19 19:04 ` [RFC/RFT PATCH 0/2] crypto: add CTS output IVs for arm64 and testmgr Ard Biesheuvel
2020-05-20 6:03 ` Stephan Mueller
2020-05-20 6:40 ` Ard Biesheuvel
2020-05-20 6:47 ` Stephan Mueller
2020-05-20 6:54 ` Ard Biesheuvel
2020-05-20 7:01 ` Stephan Mueller
2020-05-20 7:09 ` Ard Biesheuvel
2020-05-21 13:01 ` Gilad Ben-Yossef
2020-05-21 13:23 ` Ard Biesheuvel
2020-05-23 18:52 ` Stephan Müller
2020-05-23 22:40 ` Ard Biesheuvel
2020-05-28 7:33 ` Herbert Xu
2020-05-28 8:33 ` Ard Biesheuvel
2020-05-29 8:05 ` Herbert Xu
2020-05-29 8:20 ` Ard Biesheuvel
2020-05-29 11:51 ` Herbert Xu
2020-05-29 12:00 ` Ard Biesheuvel
2020-05-29 12:02 ` Herbert Xu
2020-05-29 13:10 ` Ard Biesheuvel
2020-05-29 13:19 ` Herbert Xu
2020-05-29 13:41 ` Ard Biesheuvel
2020-05-29 13:42 ` Herbert Xu
2020-06-12 12:06 ` [PATCH 0/3] crypto: skcipher - Add support for no chaining and partial chaining Herbert Xu
2020-06-12 12:07 ` [PATCH 1/3] crypto: skcipher - Add final chunk size field for chaining Herbert Xu
2020-06-12 12:15 ` Stephan Mueller
2020-06-12 12:16 ` Herbert Xu
2020-06-12 12:21 ` [v2 PATCH 0/3] crypto: skcipher - Add support for no chaining and partial chaining Herbert Xu
2020-06-12 12:21 ` [v2 PATCH 1/3] crypto: skcipher - Add final chunk size field for chaining Herbert Xu
2020-06-12 12:21 ` [v2 PATCH 2/3] crypto: algif_skcipher - Add support for fcsize Herbert Xu
2020-06-12 12:21 ` [v2 PATCH 3/3] crypto: cts - Add support for chaining Herbert Xu
2020-06-12 16:10 ` [v2 PATCH 0/3] crypto: skcipher - Add support for no chaining and partial chaining Ard Biesheuvel
2020-06-15 7:30 ` Herbert Xu
2020-06-15 7:50 ` Ard Biesheuvel
2020-06-15 18:50 ` Eric Biggers
2020-06-15 23:18 ` Ard Biesheuvel
2020-06-16 11:04 ` Herbert Xu
2020-06-16 16:53 ` Eric Biggers [this message]
2020-06-12 12:07 ` [PATCH 2/3] crypto: algif_skcipher - Add support for fcsize Herbert Xu
2020-06-12 12:07 ` [PATCH 3/3] crypto: cts - Add support for chaining Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616165354.GB40729@gmail.com \
--to=ebiggers@kernel.org \
--cc=ardb@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).