From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
Luis Chamberlain <mcgrof@kernel.org>,
LTP List <ltp@lists.linux.it>,
open list <linux-kernel@vger.kernel.org>,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
lkft-triage@lists.linaro.org, linux-crypto@vger.kernel.org,
Jan Stancek <jstancek@redhat.com>, chrubis <chrubis@suse.cz>,
"Serge E. Hallyn" <serge@hallyn.com>,
James Morris <jmorris@namei.org>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
David Howells <dhowells@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: LTP: crypto: af_alg02 regression on linux-next 20200621 tag
Date: Wed, 24 Jun 2020 10:23:35 +1000 [thread overview]
Message-ID: <20200624002335.GC12716@gondor.apana.org.au> (raw)
In-Reply-To: <20200623170217.GB150582@gmail.com>
On Tue, Jun 23, 2020 at 10:02:17AM -0700, Eric Biggers wrote:
>
> The source code for the two failing AF_ALG tests is here:
>
> https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/crypto/af_alg02.c
> https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/crypto/af_alg05.c
>
> They use read() and write(), not send() and recv().
>
> af_alg02 uses read() to read from a "salsa20" request socket without writing
> anything to it. It is expected that this returns 0, i.e. that behaves like
> encrypting an empty message.
>
> af_alg05 uses write() to write 15 bytes to a "cbc(aes-generic)" request socket,
> then read() to read 15 bytes. It is expected that this fails with EINVAL, since
> the length is not aligned to the AES block size (16 bytes).
Thanks. Sounds like it's my introduction of the init variable that
broke this. Let me investigate.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-06-24 0:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 18:34 LTP: crypto: af_alg02 regression on linux-next 20200621 tag Naresh Kamboju
2020-06-22 22:49 ` Luis Chamberlain
2020-06-23 6:23 ` Naresh Kamboju
2020-06-23 6:40 ` Herbert Xu
2020-06-23 17:02 ` Eric Biggers
2020-06-24 0:23 ` Herbert Xu [this message]
2020-06-26 6:29 ` [PATCH] crypto: af_alg - Fix regression on empty requests Herbert Xu
2020-06-27 8:31 ` Herbert Xu
2020-06-29 8:53 ` [LKP] " Naresh Kamboju
2020-06-30 8:48 ` Naresh Kamboju
2020-07-02 3:32 ` [v2 PATCH] " Herbert Xu
2020-07-03 13:35 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624002335.GC12716@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=chrubis@suse.cz \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=jstancek@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=ltp@lists.linux.it \
--cc=mcgrof@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).