Hi Ard, I love your patch! Yet something to improve: [auto build test ERROR on cryptodev/master] [also build test ERROR on crypto/master sunxi/sunxi/for-next v5.8-rc2 next-20200625] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ard-Biesheuvel/crypto-permit-asynchronous-skciphers-as-driver-fallbacks/20200625-204707 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master config: x86_64-allyesconfig (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 8911a35180c6777188fefe0954a2451a2b91deaf) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/crypto/ccp/ccp-crypto-aes-xts.c:223:28: error: incompatible pointer types passing 'struct crypto_skcipher *' to parameter of type 'struct crypto_sync_skcipher *' [-Werror,-Wincompatible-pointer-types] crypto_free_sync_skcipher(ctx->u.aes.tfm_skcipher); ^~~~~~~~~~~~~~~~~~~~~~~ include/crypto/skcipher.h:205:75: note: passing argument to parameter 'tfm' here static inline void crypto_free_sync_skcipher(struct crypto_sync_skcipher *tfm) ^ 1 error generated. vim +223 drivers/crypto/ccp/ccp-crypto-aes-xts.c 1d6b8a6f64076a Tom Lendacky 2013-11-12 218 be9fe620af63e7 Ard Biesheuvel 2019-11-09 219 static void ccp_aes_xts_exit_tfm(struct crypto_skcipher *tfm) 1d6b8a6f64076a Tom Lendacky 2013-11-12 220 { be9fe620af63e7 Ard Biesheuvel 2019-11-09 221 struct ccp_ctx *ctx = crypto_skcipher_ctx(tfm); 1d6b8a6f64076a Tom Lendacky 2013-11-12 222 7f28615df88a63 Kees Cook 2018-09-18 @223 crypto_free_sync_skcipher(ctx->u.aes.tfm_skcipher); 1d6b8a6f64076a Tom Lendacky 2013-11-12 224 } 1d6b8a6f64076a Tom Lendacky 2013-11-12 225 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org