From: Herbert Xu <herbert@gondor.apana.org.au>
To: kernel test robot <lkp@intel.com>
Cc: Olivier Sobrie <olivier.sobrie@silexinsight.com>,
kbuild-all@lists.01.org, Waleed Ziad <waleed94ziad@gmail.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH] hwrng: ba431 - Add dependency on HAS_IOMEM
Date: Tue, 30 Jun 2020 14:20:37 +1000 [thread overview]
Message-ID: <20200630042037.GA22429@gondor.apana.org.au> (raw)
In-Reply-To: <202006292036.INytijnT%lkp@intel.com>
On Mon, Jun 29, 2020 at 08:46:38PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: c28e58ee9dadc99f79cf16ca805221feddd432ad
> commit: 0289e9be5dc26d84dda6fc5492f08ca1ff599744 [1846/4145] hwrng: ba431 - add support for BA431 hwrng
> config: s390-zfcpdump_defconfig (attached as .config)
> compiler: s390-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 0289e9be5dc26d84dda6fc5492f08ca1ff599744
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> s390-linux-ld: drivers/char/hw_random/ba431-rng.o: in function `ba431_trng_probe':
> >> ba431-rng.c:(.text+0xd4): undefined reference to `devm_ioremap_resource'
This patch should fix the problem:
---8<---
The ba431 driver depends on HAS_IOMEM and this was missing from
the Kconfig file.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 0289e9be5dc2 ("hwrng: ba431 - add support for BA431 hwrng")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index 7b876dfdbaaf..edbaf6154764 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -76,6 +76,7 @@ config HW_RANDOM_ATMEL
config HW_RANDOM_BA431
tristate "Silex Insight BA431 Random Number Generator support"
+ depends on HAS_IOMEM
default HW_RANDOM
help
This driver provides kernel-side support for the Random Number
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next parent reply other threads:[~2020-06-30 4:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202006292036.INytijnT%lkp@intel.com>
2020-06-30 4:20 ` Herbert Xu [this message]
2020-06-30 6:58 ` [PATCH] hwrng: ba431 - Add dependency on HAS_IOMEM Olivier Sobrie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630042037.GA22429@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=arnd@arndb.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-crypto@vger.kernel.org \
--cc=lkp@intel.com \
--cc=olivier.sobrie@silexinsight.com \
--cc=waleed94ziad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).