Linux-Crypto Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] hwrng: ba431 - HW_RANDOM_BA431 should not default to y
@ 2020-06-30 13:39 Geert Uytterhoeven
  2020-07-09 12:54 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2020-06-30 13:39 UTC (permalink / raw)
  To: Olivier Sobrie, Waleed Ziad, Matt Mackall, Herbert Xu,
	Arnd Bergmann, Greg Kroah-Hartman
  Cc: linux-crypto, linux-kernel, Geert Uytterhoeven

As HW_RANDOM_BA431 does not have any platform dependency, it should not
default to enabled.

Fixes: 0289e9be5dc26d84 ("hwrng: ba431 - add support for BA431 hwrng")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/char/hw_random/Kconfig | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index 7b876dfdbaafe7ad..9e91c556942b1c94 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -76,7 +76,6 @@ config HW_RANDOM_ATMEL
 
 config HW_RANDOM_BA431
 	tristate "Silex Insight BA431 Random Number Generator support"
-	default HW_RANDOM
 	help
 	  This driver provides kernel-side support for the Random Number
 	  Generator hardware based on Silex Insight BA431 IP.
@@ -84,8 +83,6 @@ config HW_RANDOM_BA431
 	  To compile this driver as a module, choose M here: the
 	  module will be called ba431-rng.
 
-	  If unsure, say Y.
-
 config HW_RANDOM_BCM2835
 	tristate "Broadcom BCM2835/BCM63xx Random Number Generator support"
 	depends on ARCH_BCM2835 || ARCH_BCM_NSP || ARCH_BCM_5301X || \
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] hwrng: ba431 - HW_RANDOM_BA431 should not default to y
  2020-06-30 13:39 [PATCH] hwrng: ba431 - HW_RANDOM_BA431 should not default to y Geert Uytterhoeven
@ 2020-07-09 12:54 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2020-07-09 12:54 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Olivier Sobrie, Waleed Ziad, Matt Mackall, Arnd Bergmann,
	Greg Kroah-Hartman, linux-crypto, linux-kernel

On Tue, Jun 30, 2020 at 03:39:41PM +0200, Geert Uytterhoeven wrote:
> As HW_RANDOM_BA431 does not have any platform dependency, it should not
> default to enabled.
> 
> Fixes: 0289e9be5dc26d84 ("hwrng: ba431 - add support for BA431 hwrng")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/char/hw_random/Kconfig | 3 ---
>  1 file changed, 3 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-30 13:39 [PATCH] hwrng: ba431 - HW_RANDOM_BA431 should not default to y Geert Uytterhoeven
2020-07-09 12:54 ` Herbert Xu

Linux-Crypto Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-crypto/0 linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ https://lore.kernel.org/linux-crypto \
		linux-crypto@vger.kernel.org
	public-inbox-index linux-crypto

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-crypto


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git