From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81E0EC433E0 for ; Tue, 7 Jul 2020 08:26:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60EBF206E2 for ; Tue, 7 Jul 2020 08:26:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PaXUAVur" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727094AbgGGI0m (ORCPT ); Tue, 7 Jul 2020 04:26:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgGGI0m (ORCPT ); Tue, 7 Jul 2020 04:26:42 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CFA9C061755 for ; Tue, 7 Jul 2020 01:26:42 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id b6so44176820wrs.11 for ; Tue, 07 Jul 2020 01:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=qBb3tk+qoeCqQNbIgsA1YmfvrIH4bftpey+P/QTf7zU=; b=PaXUAVur/LkNIIW4gTLWzRAfCMGt4wNA3wl7zLKlKGszofmFes4VRd71LrL54Zy+dv 12Iu2sBGHK8msYfxPRn42uhZSwljXB2iVp0h55LeZLJLJf0mUG+vJ75Hi+R/AgU3S2pO igIovoWYwgP2LEPD5jKj4nKc9e3dTr/LUzMbjEJuTgtq2r4emkA7IM+GUM5eK/C9pmuP Ad1g+qf7IluAps2x+j5KiK1MNTzL28VnFaS9zfYaIBrKljP9JiKlPx3mYtRgilhw5USS AlgC0z9bRI6dGzw8wBwGNp2VlEwvNGzJUdV/SMTqmC90z3BY5ttiCmMwhkmcrQiPKpyz TzCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=qBb3tk+qoeCqQNbIgsA1YmfvrIH4bftpey+P/QTf7zU=; b=qXxotHkUDwvDsnFzjXZD3iI7rJxBcoppa8hqdgpq8dLZ6G3u/8n7xeYZkT6ccOzXA0 li+8UZMIUYAkRWO0HAkeLZNRD1rw1e0W19q/hC1v3fkoVWhGgTmo7BFViX/BdkAbKMdr PflC/CYoEqQ2PHjVRjG7/zCdFSh2xMJ5hSmQq6vyk5/qFOHJRyE6ll3VpOgVO9Myrf3F NXP4AZAhI1VaXYJUzzWL12KMqPmEOZp88hE8dqbp1f51Nt/X/Z7Zg1CtlBOihQidqmVv TidQavsf3C4C7brQmYrmoUdgvuCPv/i1pEFFjoXsR7TtoTFY5nN8d96E42e/l+78GK48 7Zrg== X-Gm-Message-State: AOAM533zfuZrlCJoVL2tE8zYJDVwF7xYHLgC2IsFcHFzHw9dlGmJgWYj PnTLlm5BeGnCcw8hlLjE7mBsFA== X-Google-Smtp-Source: ABdhPJxbXSBlQu+qcdR3pRtsP8xOQVgZTwMm3v38IA/dY0vx6B6HIdI+D2MPASrH+jGIIU4XWr3rCQ== X-Received: by 2002:adf:cc85:: with SMTP id p5mr51931970wrj.273.1594110400958; Tue, 07 Jul 2020 01:26:40 -0700 (PDT) Received: from dell ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id 207sm66552wme.13.2020.07.07.01.26.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 01:26:40 -0700 (PDT) Date: Tue, 7 Jul 2020 09:26:38 +0100 From: Lee Jones To: Herbert Xu Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , "David S . Miller" , linux-crypto@vger.kernel.org Subject: Re: [PATCH 1/1] crypto: ux500: hash: Add namespacing to hash_init() Message-ID: <20200707082638.GF3500@dell> References: <20200629123003.1014387-1-lee.jones@linaro.org> <20200630041029.GA20892@gondor.apana.org.au> <20200630070727.GD1179328@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200630070727.GD1179328@dell> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, 30 Jun 2020, Lee Jones wrote: > On Tue, 30 Jun 2020, Herbert Xu wrote: > > On Mon, Jun 29, 2020 at 01:30:03PM +0100, Lee Jones wrote: > > > A recent change to the Regulator consumer API (which this driver > > > utilises) add prototypes for the some suspend functions. These > > > functions require including header file include/linux/suspend.h. > > > > > > The following tree of includes affecting this driver will be > > > present: > > > > > > In file included from include/linux/elevator.h:6, > > > from include/linux/blkdev.h:288, > > > from include/linux/blk-cgroup.h:23, > > > from include/linux/writeback.h:14, > > > from include/linux/memcontrol.h:22, > > > from include/linux/swap.h:9, > > > from include/linux/suspend.h:5, > > > from include/linux/regulator/consumer.h:35, > > > from drivers/crypto/ux500/hash/hash_core.c:28: > > > > > > include/linux/elevator.h pulls in include/linux/hashtable.h which > > > contains its own version of hash_init(). This confuses the build > > > system and results in the following error (amongst others): > > > > > > drivers/crypto/ux500/hash/hash_core.c:1362:19: error: passing argument 1 of '__hash_init' from incompatible pointer type [-Werror=incompatible-pointer-types] > > > 1362 | return hash_init(req); > > > > > > Fix this by namespacing the local hash_init() such that the > > > source of confusion is removed. > > > > > > Cc: Linus Walleij > > > Cc: Herbert Xu > > > Cc: David S. Miller > > > Cc: linux-crypto@vger.kernel.org > > > Signed-off-by: Lee Jones > > > --- > > > > > > Ideally this should go into v5.8's -rcs else it runs the risk of > > > breaking when Linus pulls everything in for v5.9-rc1. > > [...] > > > I have no objections to this patch. However, I'd rather put > > it on a topic branch which you could pull rather than pushing > > it into 5.8 straight away. > > An immutable branch sounds like a sensible solution. Thanks. Any movement on this Herbert? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog