Linux-Crypto Archive on lore.kernel.org
 help / color / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tero Kristo <t-kristo@ti.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, j-keerthy@ti.com
Subject: Re: [PATCHv5 2/7] crypto: sa2ul: Add crypto driver
Date: Thu, 9 Jul 2020 18:03:01 +1000
Message-ID: <20200709080301.GA11760@gondor.apana.org.au> (raw)
In-Reply-To: <20200701080553.22604-3-t-kristo@ti.com>

On Wed, Jul 01, 2020 at 11:05:48AM +0300, Tero Kristo wrote:
> From: Keerthy <j-keerthy@ti.com>
> 
> Adds a basic crypto driver and currently supports AES/3DES
> in cbc mode for both encryption and decryption.
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> [t-kristo@ti.com: major re-work to fix various bugs in the driver and to
>  cleanup the code]
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> ---
>  drivers/crypto/Kconfig  |   14 +
>  drivers/crypto/Makefile |    1 +
>  drivers/crypto/sa2ul.c  | 1391 +++++++++++++++++++++++++++++++++++++++
>  drivers/crypto/sa2ul.h  |  380 +++++++++++
>  4 files changed, 1786 insertions(+)
>  create mode 100644 drivers/crypto/sa2ul.c
>  create mode 100644 drivers/crypto/sa2ul.h

I get lots of sparse warnings with this driver.  Please fix them
and resubmit.

../drivers/crypto/sa2ul.c:402:24: warning: incorrect type in assignment (different base types)
../drivers/crypto/sa2ul.c:402:24:    expected unsigned int [usertype]
../drivers/crypto/sa2ul.c:402:24:    got restricted __be32 [usertype]
../drivers/crypto/sa2ul.c:603:31: warning: cast to restricted __be32
../drivers/crypto/sa2ul.c:603:31: warning: cast to restricted __be32
../drivers/crypto/sa2ul.c:603:31: warning: cast to restricted __be32
../drivers/crypto/sa2ul.c:603:31: warning: cast to restricted __be32
../drivers/crypto/sa2ul.c:603:31: warning: cast to restricted __be32
../drivers/crypto/sa2ul.c:920:33: warning: missing braces around initializer
../drivers/crypto/sa2ul.c:940:33: warning: missing braces around initializer
../drivers/crypto/sa2ul.c:958:33: warning: missing braces around initializer
../drivers/crypto/sa2ul.c:972:33: warning: missing braces around initializer
../drivers/crypto/sa2ul.c:1003:35: warning: incorrect type in assignment (different base types)
../drivers/crypto/sa2ul.c:1003:35:    expected unsigned int [usertype]
../drivers/crypto/sa2ul.c:1003:35:    got restricted __be32 [usertype]
../drivers/crypto/sa2ul.c:628:41: warning: incorrect type in assignment (different base types)
../drivers/crypto/sa2ul.c:628:41:    expected unsigned int [usertype]
../drivers/crypto/sa2ul.c:628:41:    got restricted __be32 [usertype]
../drivers/crypto/sa2ul.c:528:22: warning: incorrect type in assignment (different base types)
../drivers/crypto/sa2ul.c:528:22:    expected unsigned int [usertype]
../drivers/crypto/sa2ul.c:528:22:    got restricted __be32 [usertype]
../drivers/crypto/sa2ul.c:1236:34: warning: Using plain integer as NULL pointer
../drivers/crypto/sa2ul.c:1310:27: warning: incorrect type in assignment (different base types)
../drivers/crypto/sa2ul.c:1310:27:    expected unsigned int [usertype]
../drivers/crypto/sa2ul.c:1310:27:    got restricted __be32 [usertype]
../drivers/crypto/sa2ul.c:1348:34: warning: Using plain integer as NULL pointer
../drivers/crypto/sa2ul.c:1570:33: warning: missing braces around initializer
../drivers/crypto/sa2ul.c:1586:33: warning: missing braces around initializer
../drivers/crypto/sa2ul.c:1602:33: warning: missing braces around initializer
../drivers/crypto/sa2ul.c:1658:30: warning: incorrect type in assignment (different base types)
../drivers/crypto/sa2ul.c:1658:30:    expected unsigned int [usertype]
../drivers/crypto/sa2ul.c:1658:30:    got restricted __be32 [usertype]
../drivers/crypto/sa2ul.c:1846:33: warning: missing braces around initializer
../drivers/crypto/sa2ul.c:1859:33: warning: missing braces around initializer
../drivers/crypto/sa2ul.c:1873:34: warning: Using plain integer as NULL pointer
../drivers/crypto/sa2ul.c:2167:6: warning: symbol 'sa_register_algos' was not declared. Should it be static?
../drivers/crypto/sa2ul.c:2199:6: warning: symbol 'sa_unregister_algos' was not declared. Should it be static?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01  8:05 [PATCHv5 0/7] crypto: sa2ul driver support Tero Kristo
2020-07-01  8:05 ` [PATCHv5 1/7] dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation Tero Kristo
2020-07-01  8:05 ` [PATCHv5 2/7] crypto: sa2ul: Add crypto driver Tero Kristo
2020-07-09  8:03   ` Herbert Xu [this message]
2020-07-09  8:06     ` Herbert Xu
2020-07-13  8:40       ` Tero Kristo
2020-07-01  8:05 ` [PATCHv5 3/7] crypto: sa2ul: add sha1/sha256/sha512 support Tero Kristo
2020-07-01  8:05 ` [PATCHv5 4/7] crypto: sa2ul: Add AEAD algorithm support Tero Kristo
2020-07-01  8:05 ` [PATCHv5 5/7] crypto: sa2ul: add device links to child devices Tero Kristo
2020-07-01  8:05 ` [PATCHv5 6/7] arm64: dts: ti: k3-am6: Add crypto accelarator node Tero Kristo
2020-07-01  8:05 ` [PATCHv5 7/7] arm64: dts: ti: k3-j721e-main: Add crypto accelerator node Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200709080301.GA11760@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=j-keerthy@ti.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Crypto Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-crypto/0 linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ https://lore.kernel.org/linux-crypto \
		linux-crypto@vger.kernel.org
	public-inbox-index linux-crypto

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-crypto


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git