From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH] crypto: xts - prefix function and struct names with "xts"
Date: Thu, 16 Jul 2020 21:56:18 +1000 [thread overview]
Message-ID: <20200716115618.GA31633@gondor.apana.org.au> (raw)
In-Reply-To: <20200711033428.134567-1-ebiggers@kernel.org>
Eric Biggers <ebiggers@kernel.org> wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Overly-generic names can cause problems like naming collisions,
> confusing crash reports, and reduced grep-ability. E.g. see
> commit d099ea6e6fde ("crypto - Avoid free() namespace collision").
>
> Clean this up for the xts template by prefixing the names with "xts_".
>
> (I didn't use "crypto_xts_" instead because that seems overkill.)
>
> Also constify the tfm context in a couple places, and make
> xts_free_instance() use the instance context structure so that it
> doesn't just assume the crypto_skcipher_spawn is at the beginning.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> crypto/xts.c | 137 +++++++++++++++++++++++++++------------------------
> 1 file changed, 72 insertions(+), 65 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-07-16 11:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 3:34 [PATCH] crypto: xts - prefix function and struct names with "xts" Eric Biggers
2020-07-16 11:56 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716115618.GA31633@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=arnd@arndb.de \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).