From: Sven Auhagen <sven.auhagen@voleatech.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "Van Leeuwen, Pascal" <pvanleeuwen@rambus.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 1/1] inside-secure irq balance
Date: Fri, 17 Jul 2020 08:35:04 +0200 [thread overview]
Message-ID: <20200717063504.sdmjt75oh2jp7z62@SvensMacBookAir.hq.voleatech.com> (raw)
In-Reply-To: <20200717052050.GA2045@gondor.apana.org.au>
On Fri, Jul 17, 2020 at 03:20:50PM +1000, Herbert Xu wrote:
> On Fri, Jul 17, 2020 at 07:01:34AM +0200, Sven Auhagen wrote:
> >
> > Alright, that makes sense, thank you.
> >
> > As I said in my second email yesterday, it is just a hint and not binding.
> > I run some tests and here is what happens when I disable CPU3 on my 4 Core MCBin:
>
> I don't think we should be adding policy logic like this into
> individual drivers. If the kernel should be doing this at all
> it should be done in the IRQ layer. The alternative is to do
> it in user-space through irqbalance.
I disagree as this is common practice among other kernel drivers
like ethernet.
Also this is also beeing done in other crypto drivers not to say
that the speed improvements are pretty significant.
irqbalance can of course also do the job but there is no downside
of adding the irq hint in the driver.
Best
Sven
>
> Cheers,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: https://eur03.safelinks.protection.outlook.com/?url=http:%2F%2Fgondor.apana.org.au%2F~herbert%2F&data=02%7C01%7Csven.auhagen%40voleatech.de%7C85a3fd0bef964ac07a1d08d82a112f12%7Cb82a99f679814a7295344d35298f847b%7C0%7C0%7C637305600595365880&sdata=E%2FnccG%2FNnIivbW0A2mE%2B9k89tWEWA%2B%2FcljshtLi29TI%3D&reserved=0
> PGP Key: https://eur03.safelinks.protection.outlook.com/?url=http:%2F%2Fgondor.apana.org.au%2F~herbert%2Fpubkey.txt&data=02%7C01%7Csven.auhagen%40voleatech.de%7C85a3fd0bef964ac07a1d08d82a112f12%7Cb82a99f679814a7295344d35298f847b%7C0%7C0%7C637305600595365880&sdata=e3f%2FXrlr0k9c1Cdv5kBo6zp5gtkPtkBNMNTJhB2Dg8c%3D&reserved=0
next prev parent reply other threads:[~2020-07-17 6:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 15:08 [PATCH 1/1] inside-secure irq balance Sven Auhagen
2020-07-16 7:21 ` Herbert Xu
2020-07-16 8:44 ` Van Leeuwen, Pascal
2020-07-16 9:21 ` Sven Auhagen
2020-07-16 12:04 ` Herbert Xu
2020-07-17 5:01 ` Sven Auhagen
2020-07-17 5:20 ` Herbert Xu
2020-07-17 6:35 ` Sven Auhagen [this message]
2020-07-17 6:57 ` Herbert Xu
2020-07-17 7:53 ` Sven Auhagen
2020-07-17 8:56 ` Van Leeuwen, Pascal
2020-07-17 13:50 ` Herbert Xu
2020-07-16 10:31 ` Sven Auhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717063504.sdmjt75oh2jp7z62@SvensMacBookAir.hq.voleatech.com \
--to=sven.auhagen@voleatech.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=pvanleeuwen@rambus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).