From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95073C433E1 for ; Fri, 17 Jul 2020 06:43:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 792272071A for ; Fri, 17 Jul 2020 06:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbgGQGnk (ORCPT ); Fri, 17 Jul 2020 02:43:40 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:42854 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726180AbgGQGnj (ORCPT ); Fri, 17 Jul 2020 02:43:39 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jwK5f-0005nT-RC; Fri, 17 Jul 2020 16:43:28 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 17 Jul 2020 16:43:27 +1000 Date: Fri, 17 Jul 2020 16:43:27 +1000 From: Herbert Xu To: Ard Biesheuvel Cc: Colin King , "David S . Miller" , Linux Crypto Mailing List , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] crypto: xts: use memmove to avoid overlapped memory copy Message-ID: <20200717064327.GA2504@gondor.apana.org.au> References: <20200716152900.1709694-1-colin.king@canonical.com> <20200717052139.GB2045@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Jul 17, 2020 at 08:59:54AM +0300, Ard Biesheuvel wrote: > > Or change it to b[1] = b[0] (assuming the compiler allows struct > assignment in that way). This will always copy XTS_BLOCK_SIZE bytes, > but we have sufficient space, and it is probably more efficient too > in most cases. Sounds good to me. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt