From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C031EC433E2 for ; Fri, 17 Jul 2020 06:57:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A61DB20734 for ; Fri, 17 Jul 2020 06:57:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727938AbgGQG5q (ORCPT ); Fri, 17 Jul 2020 02:57:46 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:42888 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726113AbgGQG5q (ORCPT ); Fri, 17 Jul 2020 02:57:46 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jwKJO-00064n-Qe; Fri, 17 Jul 2020 16:57:39 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 17 Jul 2020 16:57:38 +1000 Date: Fri, 17 Jul 2020 16:57:38 +1000 From: Herbert Xu To: Sven Auhagen Cc: "Van Leeuwen, Pascal" , "linux-crypto@vger.kernel.org" Subject: Re: [PATCH 1/1] inside-secure irq balance Message-ID: <20200717065738.GC2504@gondor.apana.org.au> References: <20200708150844.2626m3pgdo5oidzm@SvensMacBookAir.sven.lan> <20200716072133.GA28028@gondor.apana.org.au> <20200716092136.j4xt2s4ogr7murod@SvensMacbookPro.hq.voleatech.com> <20200716120420.GA31780@gondor.apana.org.au> <20200717050134.dk5naairvhmyyxyu@SvensMacBookAir.sven.lan> <20200717052050.GA2045@gondor.apana.org.au> <20200717063504.sdmjt75oh2jp7z62@SvensMacBookAir.hq.voleatech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200717063504.sdmjt75oh2jp7z62@SvensMacBookAir.hq.voleatech.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Jul 17, 2020 at 08:35:04AM +0200, Sven Auhagen wrote: > > I disagree as this is common practice among other kernel drivers > like ethernet. > Also this is also beeing done in other crypto drivers not to say > that the speed improvements are pretty significant. > > irqbalance can of course also do the job but there is no downside > of adding the irq hint in the driver. If you're going to do this please at least use the function cpumask_local_spread. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt