Linux-Crypto Archive on
 help / color / Atom feed
From: Marco Felsch <>
To: Christian Eggers <>
Cc: Fabio Estevam <>,
	Martin Kaiser <>,
	Herbert Xu <>,
	Arnd Bergmann <>,
	Greg Kroah-Hartman <>,
	Sascha Hauer <>,, NXP Linux Team <>,
	Pengutronix Kernel Team <>,
	Matt Mackall <>, Shawn Guo <>,,
Subject: Re: [PATCH] hwrng: imx-rngc - setup default RNG quality
Date: Tue, 28 Jul 2020 09:48:17 +0200
Message-ID: <> (raw)
In-Reply-To: <>

Hi Christian,

On 20-07-27 14:45, Christian Eggers wrote:
> When hw_random device's quality is non-zero, it will automatically fill
> the kernel's entropy pool at boot.  For this purpose, one conservative
> quality value is being picked up as the default value.

IMHO your value is not conservative enough and the commit message should
explain why we should use 900. Unfortunately I had not enough time to
send my patch addressing this. However please check my commit message
why 900 is not good:

From 9f047eee5e4ce8353c9b764a47e7f584b2013347 Mon Sep 17 00:00:00 2001
From: Marco Felsch <>
Date: Thu, 7 May 2020 12:01:28 +0200
Subject: [PATCH] hwrng: imx-rngc - add quality to use it as kernel entropy

The RM describes the RNGB as follow:
The RNGB uses the True Random Number Generator (TRNG) and a
Pseudo-Random Number Generator (PRNG) to achieve a true randomness and
cryptographic strength.

The RNGB has 3 operation modes: self-test, seed-generation and the final
'random number generation' mode. Befor we can retrieve random numbers
from the RNGB we need to generate the seed pool:
During the seed generation, the RNGB adds the entropy generated in the
TRNG to the 256-bit XKEY register. The PRNG algorithm executes 20.000
entropy samples from the TRNG to create an initial seed for the random
number generation.

The RNGB can generate 2^20 words (4byte) of 'random' data after the
seed pool was initialized. The pool needs to be reseeded if more words
are required. The reseeding is done automatically since
commit 3acd9ea9331c ("hwrng: imx-rngc - use automatic seeding").

We can't retrieve the TRNG values directly so we need a other way to get
the quality level. We know that the PRNG uses 20.000 entropy samples
from the TRNG to generate 2^20 words (1MiB) and the quality level is
defined as (in bits of entropy per 1024 bits of input). So the quality
level can be calculated by:

   20.000 * 1024
   ------------- = ~ 19.5

Signed-off-by: Marco Felsch <>
 drivers/char/hw_random/imx-rngc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
index 9c47e431ce90..61c844baf26e 100644
--- a/drivers/char/hw_random/imx-rngc.c
+++ b/drivers/char/hw_random/imx-rngc.c
@@ -285,6 +285,7 @@ static int imx_rngc_probe(struct platform_device *pdev)
 	rngc->rng.init = imx_rngc_init;
 	rngc-> = imx_rngc_read;
 	rngc->rng.cleanup = imx_rngc_cleanup;
+	rngc->rng.quality = 19;
 	rngc->dev = &pdev->dev;
 	platform_set_drvdata(pdev, rngc);

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27 10:57 [PATCH] Support for RNGB on i.MX6 ULL Christian Eggers
2020-07-27 10:57 ` [PATCH 1/3] ARM: dts: imx6ull: Add rngb node Christian Eggers
2020-07-27 11:36   ` Fabio Estevam
2020-07-27 12:45     ` [PATCH] hwrng: imx-rngc - setup default RNG quality Christian Eggers
2020-07-28  7:48       ` Marco Felsch [this message]
2020-07-28  8:47         ` Christian Eggers
2020-07-27 10:57 ` [PATCH 2/3] hwrng: imx-rngc - make clock optional Christian Eggers
2020-07-27 10:57 ` [PATCH 3/3] hwrng: imx-rngc - setup default RNG quality Christian Eggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Crypto Archive on

Archives are clonable:
	git clone --mirror linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ \
	public-inbox-index linux-crypto

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone