Linux-Crypto Archive on lore.kernel.org
 help / color / Atom feed
* [PATCHv2 1/2] hwrng: optee: handle unlimited data rates
@ 2020-07-23  8:46 Jorge Ramirez-Ortiz
  2020-07-23  8:46 ` [PATCHv2 2/2] hwrng: optee: fix wait use case Jorge Ramirez-Ortiz
  2020-07-24 13:24 ` [PATCHv2 1/2] hwrng: optee: handle unlimited data rates Sumit Garg
  0 siblings, 2 replies; 14+ messages in thread
From: Jorge Ramirez-Ortiz @ 2020-07-23  8:46 UTC (permalink / raw)
  To: jorge, sumit.garg, mpm, herbert
  Cc: jens.wiklander, arnd, ricardo, mike, gregkh, op-tee,
	linux-crypto, linux-kernel

Data rates of MAX_UINT32 will schedule an unnecessary one jiffy
timeout on the call to msleep. Avoid this scenario by using 0 as the
unlimited data rate.

Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
---
 drivers/char/hw_random/optee-rng.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/optee-rng.c
index 49b2e02537dd..5bc4700c4dae 100644
--- a/drivers/char/hw_random/optee-rng.c
+++ b/drivers/char/hw_random/optee-rng.c
@@ -128,7 +128,7 @@ static int optee_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
 		data += rng_size;
 		read += rng_size;
 
-		if (wait) {
+		if (wait && pvt_data->data_rate) {
 			if (timeout-- == 0)
 				return read;
 			msleep((1000 * (max - read)) / pvt_data->data_rate);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, back to index

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23  8:46 [PATCHv2 1/2] hwrng: optee: handle unlimited data rates Jorge Ramirez-Ortiz
2020-07-23  8:46 ` [PATCHv2 2/2] hwrng: optee: fix wait use case Jorge Ramirez-Ortiz
2020-07-24 13:22   ` Sumit Garg
2020-07-24 14:23     ` Jorge Ramirez-Ortiz, Foundries
2020-07-28 10:05       ` Jorge Ramirez-Ortiz, Foundries
2020-08-05 13:49       ` Sumit Garg
2020-08-05 20:38         ` Jorge Ramirez-Ortiz, Foundries
2020-08-06  6:11           ` Sumit Garg
2020-08-06  6:30             ` Jorge Ramirez-Ortiz, Foundries
2020-08-06  6:57               ` Sumit Garg
2020-08-06  8:14                 ` Jorge Ramirez-Ortiz, Foundries
2020-08-06  9:15                   ` Sumit Garg
2020-08-05 13:34   ` Jorge Ramirez-Ortiz, Foundries
2020-07-24 13:24 ` [PATCHv2 1/2] hwrng: optee: handle unlimited data rates Sumit Garg

Linux-Crypto Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-crypto/0 linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ https://lore.kernel.org/linux-crypto \
		linux-crypto@vger.kernel.org
	public-inbox-index linux-crypto

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-crypto


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git