From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7770AC433E0 for ; Tue, 28 Jul 2020 17:22:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F56020786 for ; Tue, 28 Jul 2020 17:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731779AbgG1RWs (ORCPT ); Tue, 28 Jul 2020 13:22:48 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:56276 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731684AbgG1RWs (ORCPT ); Tue, 28 Jul 2020 13:22:48 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1k0TJH-0001fV-La; Wed, 29 Jul 2020 03:22:40 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Wed, 29 Jul 2020 03:22:39 +1000 Date: Wed, 29 Jul 2020 03:22:39 +1000 From: Herbert Xu To: Eric Biggers Cc: Ard Biesheuvel , Stephan Mueller , Linux Crypto Mailing List Subject: Re: [v3 PATCH 1/31] crypto: skcipher - Add final chunk size field for chaining Message-ID: <20200728172239.GA3539@gondor.apana.org.au> References: <20200728071746.GA22352@gondor.apana.org.au> <20200728171512.GB4053562@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200728171512.GB4053562@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jul 28, 2020 at 10:15:12AM -0700, Eric Biggers wrote: > > Shouldn't chaining be disabled by default? This is inviting bugs where drivers > don't implement chaining, but leave final_chunksize unset (0) which apparently > indicates that chaining is supported. I've gone through everything and the majority of algorithms do support chaining so I think defaulting to on makes more sense. For now we have some algorithms that can be chained but the drivers do not allow it, this is not something that I'd like to see in new drivers. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt