Linux-Crypto Archive on lore.kernel.org
 help / color / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: "Horia Geantă" <horia.geanta@nxp.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"André Draszik" <git@andred.net>,
	"Robin Gong" <yibin.gong@nxp.com>,
	"Anson Huang" <anson.huang@nxp.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Aymen Sghaier" <aymen.sghaier@nxp.com>,
	"Adam Ford" <aford173@gmail.com>,
	linux-input@vger.kernel.org, linux-crypto@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"NXP Linux Team" <linux-imx@nxp.com>
Subject: Re: [PATCH v3 3/3] Input: snvs_pwrkey - only IRQ_HANDLED for our own events
Date: Wed, 29 Jul 2020 23:06:01 -0700
Message-ID: <20200730060601.GE1665100@dtor-ws> (raw)
In-Reply-To: <20200729075513.ckjnhfv3dxuesvsi@pengutronix.de>

Hi Marco,

On Wed, Jul 29, 2020 at 09:55:13AM +0200, Marco Felsch wrote:
> Hi,
> 
> On 20-07-23 10:43, Horia Geantă wrote:
> > From: André Draszik <git@andred.net>
> > 
> > The snvs_pwrkey shares the SNVS LPSR status register with the snvs_rtc.
> > 
> > This driver here should only return IRQ_HANDLED if the status register
> > indicates that the event we're handling in the irq handler was genuinely
> > intended for this driver. Otheriwse the interrupt subsystem will
> > assume the interrupt was handled successfully even though it wasn't
> > at all.
> 
> After checking the RM and the imx6qdl.dtsi I'm not very sure that this
> is right since the snvs-powerkey has a seperate irq-line. So we can be
> sure that this irq is for us. If this is the case we don't need to check
> the SNVS_LPSR_REG instead we only need to clear it.

Wouldn't we want to know if for some reason we get spurious interrupts?

Thanks.

-- 
Dmitry

  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23  7:43 [PATCH v3 0/3] input: i.MX snvs powerkey updates Horia Geantă
2020-07-23  7:43 ` [PATCH v3 1/3] dt-bindings: crypto: fsl-sec4: add snvs clock to pwrkey Horia Geantă
2020-07-23  7:43 ` [PATCH v3 2/3] Input: snvs_pwrkey - enable snvs clock as needed Horia Geantă
2020-07-29  7:33   ` Marco Felsch
2020-07-30  6:04     ` Dmitry Torokhov
2020-07-30  8:54       ` Marco Felsch
2020-07-23  7:43 ` [PATCH v3 3/3] Input: snvs_pwrkey - only IRQ_HANDLED for our own events Horia Geantă
2020-07-29  7:55   ` Marco Felsch
2020-07-30  6:06     ` Dmitry Torokhov [this message]
2020-07-30  8:59       ` Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200730060601.GE1665100@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=aford173@gmail.com \
    --cc=anson.huang@nxp.com \
    --cc=aymen.sghaier@nxp.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=git@andred.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=yibin.gong@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Crypto Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-crypto/0 linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ https://lore.kernel.org/linux-crypto \
		linux-crypto@vger.kernel.org
	public-inbox-index linux-crypto

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-crypto


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git