From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96C92C433E1 for ; Tue, 18 Aug 2020 14:05:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A21D2076D for ; Tue, 18 Aug 2020 14:05:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726605AbgHROFg (ORCPT ); Tue, 18 Aug 2020 10:05:36 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:42824 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbgHROFf (ORCPT ); Tue, 18 Aug 2020 10:05:35 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1k82F2-0006ut-AZ; Wed, 19 Aug 2020 00:05:33 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Wed, 19 Aug 2020 00:05:32 +1000 Date: Wed, 19 Aug 2020 00:05:32 +1000 From: Herbert Xu To: Ben Greear Cc: Ard Biesheuvel , Linux Crypto Mailing List , Eric Biggers Subject: Re: [PATCH 0/5] crypto: Implement cmac based on cbc skcipher Message-ID: <20200818140532.GA25807@gondor.apana.org.au> References: <20200802090616.1328-1-ardb@kernel.org> <20200818082410.GA24497@gondor.apana.org.au> <20200818135128.GA25652@gondor.apana.org.au> <2aad9569-877e-4398-88ef-e40d9bbf7656@candelatech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2aad9569-877e-4398-88ef-e40d9bbf7656@candelatech.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Aug 18, 2020 at 06:56:12AM -0700, Ben Greear wrote: > > Herbert, thanks for working on this. If I apply the patches you posted, > that is expected to provide wifi aes decryption speedup similar to what > the original patch I sent does? Or, are additional patches needed? It depends on whether the wifi code uses the async ahash interface, if not it probably won't make much of an impact at all. I just checked and if the code you're using is net/mac80211/aes_cmac.c then it's using shash so it won't really benefit from this. However, there's no reason why mac80211 can't be converted over to async as we did for IPsec. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt